Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1172052pxf; Fri, 26 Mar 2021 02:36:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywJNx0ZFUFz8Bs4PRyZhg2DVM7qUBbnTd1Wxn30uEjwROtxHrZZ9QWZJL8G9z0SOHJGRiZ X-Received: by 2002:a17:906:f210:: with SMTP id gt16mr14224727ejb.206.1616751410377; Fri, 26 Mar 2021 02:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616751410; cv=none; d=google.com; s=arc-20160816; b=P6ZjzKsTMMDXFbLN0j7xpyWG1wNt+QPXIE7S5MMqGYlrPjNcKsEJm5yvLBHpghLE0h HxqYYxOsKRPA0FvAVTRlG/FGTcaUDazQ1R0o1Ik4pydsiwSzFRo/VwyvJfQpDz6IMcj4 +Yr0hb8It0jBl2BGKeXQfckIPWjULyNVdx0QClrYDQu3Qe+BqGTxsELdxd/TmOVPqRKz w6QGTQR/me00PSIkLUCnA/xgdaxgc5JMHKJRe7mGLslxaoTEnvfLWQF9TM460iIBgmZo P4B0M2KK0+a+XqmclerEOSIaoxwIJb3GYIVw3c6z23AeYAPN8QGYZzNwSvVS/p37Cs1L 1vJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XqcorEVYiepCithhd9yJamjX6+vLZeffLcSquVosbkg=; b=MTke+sbCGx5vePbpkRmM9nMd0VA5rzXexlmfQHoKLmcOD+Hw10ckFbTkqB715L+ozq RD4oEK/iHktnk7VJd1YJPgSPtCTwMoVyF9Dq/o7EEmlqB3C9KxEjF/alURPc5VskHjSM m/wfFUM8A8yoQvpcMRfNTbeDsHQA2m2iCe6n1MVUHN3yRneTWhQBFZ8ewz31xUz9xkUE QbVHJ0OdIhJVBGyQ3xfTyhqQM20Geec0dEWqNs1qxKHp04B3PptPxZJDVvGYm1HJVEes VTrPEscJSjqHAVMfYGsIVEisxRj3PcGTo3c/qm2A6h/5nT7U4JIPSYxsO2IZg8ICFlqc ozBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de11si6161934edb.15.2021.03.26.02.36.26; Fri, 26 Mar 2021 02:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbhCZJfg (ORCPT + 99 others); Fri, 26 Mar 2021 05:35:36 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:35608 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230135AbhCZJfE (ORCPT ); Fri, 26 Mar 2021 05:35:04 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lPirI-0003cX-LR; Fri, 26 Mar 2021 20:34:25 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Mar 2021 20:34:24 +1100 Date: Fri, 26 Mar 2021 20:34:24 +1100 From: Herbert Xu To: Aditya Srivastava Cc: leitao@debian.org, lukas.bulwahn@gmail.com, corbet@lwn.net, rdunlap@infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, nayna@linux.ibm.com, pfsmorigo@gmail.com, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, davem@davemloft.net, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: vmx: fix incorrect kernel-doc comment syntax in files Message-ID: <20210326093424.GP12658@gondor.apana.org.au> References: <20210320202525.12562-1-yashsri421@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320202525.12562-1-yashsri421@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Mar 21, 2021 at 01:55:25AM +0530, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are certain files in drivers/crypto/vmx, which follow this syntax, > but the content inside does not comply with kernel-doc. > Such lines were probably not meant for kernel-doc parsing, but are parsed > due to the presence of kernel-doc like comment syntax(i.e, '/**'), which > causes unexpected warnings from kernel-doc. > > E.g., presence of kernel-doc like comment in the header line for > drivers/crypto/vmx/vmx.c causes this warning by kernel-doc: > > "warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead" > > Similarly for other files too. > > Provide a simple fix by replacing such occurrences with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava > --- > * Applies perfectly on next-20210319 > > drivers/crypto/vmx/aes.c | 2 +- > drivers/crypto/vmx/aes_cbc.c | 2 +- > drivers/crypto/vmx/aes_ctr.c | 2 +- > drivers/crypto/vmx/aes_xts.c | 2 +- > drivers/crypto/vmx/ghash.c | 2 +- > drivers/crypto/vmx/vmx.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt