Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp255907pxf; Wed, 31 Mar 2021 02:34:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmJ932ejAc/6NQVC/RzKXLw5EGv3QeByILEARs82p+bB7YN54L9hwTjIrGmrRq2OCetyTC X-Received: by 2002:a17:906:d10b:: with SMTP id b11mr2556917ejz.144.1617183264135; Wed, 31 Mar 2021 02:34:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617183264; cv=none; d=google.com; s=arc-20160816; b=acUfp8OKfEKsU+UB7lWrilI2TL0A0RUp2ANH4R1npKXuPEFyq1UnssCZOixbNa5778 3sSvBDY/X3/bHEmjT4ZO9BnDhZcpWA+tAuMoM0yvQ5obnUSVV07WsjQnOK+m8QUjwLnT e0WdWgFVXGsuvrG4MIiagS/7LyitFq4dWbhL8PKZPjSybU17QIh7+gnwgNHIJDVssaLl ZYOICW/GmnM5f8KZ3HCChL+cR/XlSU8HisEFuQIuYZyEQJ0LuQl7tIDOZT0fjUlxNSOy fBfqkKJK4nw400xbJABJ8kMvnzw0FZrSOlBCw5GX8oVp0OjKqHgFv9T32hx6AMMA5j1s PU3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=c3oqnFMhISODzDv/bewQMxXHr3FQc4iFOS1pOy14cj4=; b=bwVJfU8BCB9adhzVbOsyeZdPri9mK+ZF1T1iSyAkP17oWiQI9XTtOpjLLX+ZCOrWDG 3DoK1m2OpYOFiOcFdkr0bdx2anBQLKHb1n57UvLeX3gsWSgXAMlruZA1UCLjpakIsNWA quBwc4VjtWfaPkzOl8UBJzMc9/I3qBy9+jg5JtLZUwK39SeWMRdu1At6OxkWvTxGQhIP QEIEdJA26gQ3g+r3zY73urzQ+DSLRAxBCdm4K2ykd9EPuc1TEl0wCRVaKcK1kwOq/UEQ kPX4FC+SvMRzyIMVTF5ApRggxrPlP3Wo6tHBHURWPHDc4IOmYVJ/Z2FvByk2Op8h3MGs 1q5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx20si1319814edb.215.2021.03.31.02.33.52; Wed, 31 Mar 2021 02:34:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234544AbhCaJd0 (ORCPT + 99 others); Wed, 31 Mar 2021 05:33:26 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15057 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234375AbhCaJdL (ORCPT ); Wed, 31 Mar 2021 05:33:11 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F9Ldf5dqxzNrK7; Wed, 31 Mar 2021 17:30:30 +0800 (CST) Received: from huawei.com (10.67.165.24) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Wed, 31 Mar 2021 17:33:02 +0800 From: Kai Ye To: CC: , , , Subject: [PATCH v2 3/5] crypto: hisilicon/sgl - add some dfx logs Date: Wed, 31 Mar 2021 17:30:30 +0800 Message-ID: <1617183032-30983-4-git-send-email-yekai13@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1617183032-30983-1-git-send-email-yekai13@huawei.com> References: <1617183032-30983-1-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Add some dfx logs in some abnormal exit situations. Signed-off-by: Kai Ye --- drivers/crypto/hisilicon/sgl.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c index b8a811f..d04e551 100644 --- a/drivers/crypto/hisilicon/sgl.c +++ b/drivers/crypto/hisilicon/sgl.c @@ -90,8 +90,10 @@ struct hisi_acc_sgl_pool *hisi_acc_create_sgl_pool(struct device *dev, block[i].sgl = dma_alloc_coherent(dev, block_size, &block[i].sgl_dma, GFP_KERNEL); - if (!block[i].sgl) + if (!block[i].sgl) { + dev_err(dev, "Fail to allocate hw SG buffer!\n"); goto err_free_mem; + } block[i].size = block_size; } @@ -100,8 +102,10 @@ struct hisi_acc_sgl_pool *hisi_acc_create_sgl_pool(struct device *dev, block[i].sgl = dma_alloc_coherent(dev, remain_sgl * sgl_size, &block[i].sgl_dma, GFP_KERNEL); - if (!block[i].sgl) + if (!block[i].sgl) { + dev_err(dev, "Fail to allocate remained hw SG buffer!\n"); goto err_free_mem; + } block[i].size = remain_sgl * sgl_size; } @@ -216,16 +220,19 @@ hisi_acc_sg_buf_map_to_hw_sgl(struct device *dev, sg_n = sg_nents(sgl); sg_n_mapped = dma_map_sg(dev, sgl, sg_n, DMA_BIDIRECTIONAL); - if (!sg_n_mapped) + if (!sg_n_mapped) { + dev_err(dev, "DMA mapping for SG error!\n"); return ERR_PTR(-EINVAL); + } if (sg_n_mapped > pool->sge_nr) { - dma_unmap_sg(dev, sgl, sg_n, DMA_BIDIRECTIONAL); + dev_err(dev, "the number of entries in input scatterlist is bigger than SGL pool setting.\n"); return ERR_PTR(-EINVAL); } curr_hw_sgl = acc_get_sgl(pool, index, &curr_sgl_dma); if (IS_ERR(curr_hw_sgl)) { + dev_err(dev, "Get SGL error!\n"); dma_unmap_sg(dev, sgl, sg_n, DMA_BIDIRECTIONAL); return ERR_PTR(-ENOMEM); -- 2.8.1