Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp621732pxf; Wed, 31 Mar 2021 11:37:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYDs7BedSaP0fVhjrDUdTcF59nPDApBy0dDTL0M/L8h7Wp/w9mxoZ+ZIuO90q5UWgi/MbX X-Received: by 2002:a17:906:1f93:: with SMTP id t19mr5171673ejr.443.1617215846742; Wed, 31 Mar 2021 11:37:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617215846; cv=none; d=google.com; s=arc-20160816; b=z2CnkaH/KmpBv02wLYuNBHJGTfLxUkHUYbzgBHOBp9/0J9z4w8XP//XjRSO27vp3yi oUwQyYNEsE7d0tJ3tDerq+ryGa/TndHV6gJSIagbBmQxDLIm1KsagjQjDaZoPE+LbGE2 fCSnOCbjjvKC3yTI3F79YJ/Tuu0xmOVNPM2m4pyggbqONCFAthfMAgvibH0tOf/E+0OH ANeFT7F4ljQmTy/gaB6cfQdX1EqDyZpvFSwMrADdzG1pdamDExALyQiOwZhnpkYCgvO+ iqm+KXXCn0x5cCZvmw8BFTOK+0qrqL1PmUe1SON/eF4iPFShfcTxlgr7LpVVxJiZCocX JkTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TnW+eMwf8VjqXvYN2+uEls9zSiM8xbgpZnfblzmT7Rk=; b=ITcvpstVVUQfkkzSCuGHpq/9eB8sYqNoPx9konc2LlXSEv7rii9HyAScSDtZ5l1Wc3 NIyOSm2OsBpqBtAcwXjhMDWiG8waYIqxWdkIirEC9VxLEZ/D78sJIVxgJqt+GyhsQKoq XvismYZbcw8ZqSGJYKK2olbvW6oBfaUCEY94x5JmsYWyEMfwpIKnpx1vFly/CDtbKMEv 8hCu1NaVn/vz3zRo0b2ur8Cmzra9WyTpSFKdUHp8BWG8WArdIRJJgoFlYvicA0oeOcJ2 8/EnOBjMKQRsKNgxZy/pXFa54os/uqp35Lf/1d6LqEM2uE/Vr0S/aj9qUMeWGGc5lbK0 SkfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OXoBi7ZQ; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r7si2485552edt.237.2021.03.31.11.36.55; Wed, 31 Mar 2021 11:37:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OXoBi7ZQ; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235090AbhCaSgV (ORCPT + 99 others); Wed, 31 Mar 2021 14:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235263AbhCaSf7 (ORCPT ); Wed, 31 Mar 2021 14:35:59 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE956C061574; Wed, 31 Mar 2021 11:35:58 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id 1so14518521qtb.0; Wed, 31 Mar 2021 11:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TnW+eMwf8VjqXvYN2+uEls9zSiM8xbgpZnfblzmT7Rk=; b=OXoBi7ZQJeMNsz5QjkZ4wDlks3q4SsHCsdYtaWC8FLARKplDkQ1oZoVeQvXagLweFI u2TebfZLjGY3vBcRAqPx4dw4rFPrTV+nNnVvKvl2cVdQnqSYadYbVtvFeqOfZfyASKOS NTKWPtJnsqikVv4EVvkNCceKJ6caygF1WpFkWpzYCvhHOBEvxyslKPEZVcah5/lU0+p6 CwkIJQwb91DR41ylnG5cSt+c21CyHusgkvNlT5Aeb90vB+llYi3Gt1e3mgv8Tg/7Qayl C4bSmfEzcsq/0upNzYb+KAC1WcPoRG4GoHU6JNNdp8sZEpveK5txF4k8y5tWpCdw6KRF YTgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TnW+eMwf8VjqXvYN2+uEls9zSiM8xbgpZnfblzmT7Rk=; b=QPNnsUQX+POu+DiXBJYrJeRhA3ogtvR3qwzzcmFYHMi63mfUkQFaSHHttcfWpXeE+f njVRYxvit65gC9ktWrNr5ApZqD0BhMiegh3JLm5sE0KfsRLzYkBRk6snIQljx82gXhfk kcpar7jKrs7TUeXiiC3fEG9zGJ0WekGZWtThexENJfySJk928eSioHTALJu4sdqmT4/n 7Cd6gAbVnbsaPPla1h4dm3QwYkSB1QYBoB3cSH3MCTnYclvGl2XW9h3bw7iUnL1rlIaR jDiOuXvQS4iQKknU6/GysGgM598F85lYEsrM+C11XdbEzH7u6jyr4aA/HyhGOMARLSQA PCDg== X-Gm-Message-State: AOAM5314C9CU9aj9K2unZvjfpEcPaTqh0URp8x/9TK4TcHYGF7QilcrR 0NyLp4BOxtnpBhpkUQ2zH+KZSOKYvYQJ52S1Cl7caHDTQDFcPw== X-Received: by 2002:ac8:6d2b:: with SMTP id r11mr3644315qtu.245.1617215757388; Wed, 31 Mar 2021 11:35:57 -0700 (PDT) MIME-Version: 1.0 References: <319e558e1bd19b80ad6447c167a2c3942bdafea2.1615914058.git-series.a.fatoum@pengutronix.de> In-Reply-To: <319e558e1bd19b80ad6447c167a2c3942bdafea2.1615914058.git-series.a.fatoum@pengutronix.de> From: Richard Weinberger Date: Wed, 31 Mar 2021 20:35:45 +0200 Message-ID: Subject: Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys To: Ahmad Fatoum Cc: Jonathan Corbet , David Howells , Jarkko Sakkinen , James Bottomley , Mimi Zohar , kernel@pengutronix.de, James Morris , "Serge E. Hallyn" , =?UTF-8?Q?Horia_Geant=C4=83?= , Aymen Sghaier , Herbert Xu , "David S. Miller" , Udit Agarwal , Jan Luebbe , David Gstir , Franck LENORMAND , Sumit Garg , keyrings@vger.kernel.org, Linux Crypto Mailing List , linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org, LKML , LSM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Ahmad, On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote: > +#define KEYMOD "kernel:trusted" why is the CAAM key modifier hard coded? I'd love to have way to pass my own modifier. That way existing blobs can also be used with this implementation. IIRC the NXP vendor tree uses "SECURE_KEY" as default modifier. -- Thanks, //richard