Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/1] use crc32 instead of md5 for hibernation e820
 integrity check
To:     Chris von Recklinghausen <crecklin@redhat.com>, ardb@kernel.org,
        simo@redhat.com, rafael@kernel.org, decui@microsoft.com,
        linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210401122458.12663-1-crecklin@redhat.com>
From:   Christophe Leroy <christophe.leroy@csgroup.eu>
Message-ID: <22595ae7-2ab5-2e6b-01d7-6b284dc8b0c2@csgroup.eu>
Date:   Thu, 1 Apr 2021 20:47:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210401122458.12663-1-crecklin@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Precedence: bulk


Le 01/04/2021 à 14:24, Chris von Recklinghausen a écrit :
> Currently, suspend on x86_64 fails when FIPS mode is enabled because it uses md5
> to generate a digest of the e820 region. MD5 is not FIPS compliant so an error
> is reported and the suspend fails.
> 
> MD5 is used only to create a digest to ensure integrity of the region, no actual
> encryption is done. This patch set changes the integrity check to use crc32
> instead of md5 since crc32 is available in both FIPS and non-FIPS modes.

Why not put all those explanations in the patch itself ?

Because text in the cover is lost, so a cover is not really usefull for a single patch.

> 
> Chris von Recklinghausen (1):
>    use crc32 instead of md5 for hibernation image integrity check
> 
>   arch/x86/power/hibernate.c | 31 +++++++++++++++++--------------
>   1 file changed, 17 insertions(+), 14 deletions(-)
>