Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1076360pxf; Fri, 2 Apr 2021 00:07:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyf4KabesKCXIC/+mBF0LwNL5YrNmHxZ+GYNFTQUeqOKtrrWvELCR3Po0UEU/FZxejJotpU X-Received: by 2002:a05:6602:24d4:: with SMTP id h20mr9942492ioe.4.1617347224479; Fri, 02 Apr 2021 00:07:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617347224; cv=none; d=google.com; s=arc-20160816; b=GsbXpaJ2e7clQeIu/5PqZQ1QKyQAL4adnR2Yoy3x9u/nleix25lY0evP7SO11qP4is JNPWsC60860BJ61KQFTWer7SY+CCS2awrsd0sIX7IFSfLCUkrCBGDXsOzQp8f8Z7A4Zd 02iZwZlDn50rvRr8ht59diFpeoczG3VvHfH1wT+zRgA0p0KxuD7ib8HZH3iZY3qoFmh4 phgmfd/ylxtby8VvCG5OhjgU8FH6tOcVzQSgI5pJ+m98nLgx3cA6ZdQ7O1IfdcD0CIXH wfXw9Z+7ifASTHuDngMJTW4dgThag4QtErddgVd3FU+WvuYn3/bVLpmqQ8C9EyKzANqI DDoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=8ndtPB8fEZuPcHoqIkuGRrImCNICNOlS10MtQmqvkyo=; b=YPO78S9fcCvwMaE9Ab51D1Op3RYAxNYS0SsVNQ7NcE7ynRCloroVL/Xi8CY79lUTv5 14YWItpsuzbe4p1gWGFaIkuCkGyyuydngt/lkieR6BMMJ5iBVx9mx+HWU5DfDqPwJkxn 0EjqoV2kvv0IC88ZUBYo1wyJfFuKPx7NBpw7q3KDxnZFj137wZnKw8ku19rY7ymz9bQU Bm6X2cSWSPcl/Zd0RXZbsleV5rvxJj1seAOsKBGpDYkDcXH8gmN2TuiTPVDeis6gHBzj 5zBZbnP6D5JQssCCphzExsFhn71m/KBps1PUFGlaCmttVY2gBypbTLkPfPiW8VTFL3qk mV9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si7135730jan.85.2021.04.02.00.06.49; Fri, 02 Apr 2021 00:07:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbhDBHGq (ORCPT + 99 others); Fri, 2 Apr 2021 03:06:46 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:51420 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbhDBHGp (ORCPT ); Fri, 2 Apr 2021 03:06:45 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lSDtB-0001Hi-0e; Fri, 02 Apr 2021 18:06:42 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 02 Apr 2021 18:06:40 +1100 Date: Fri, 2 Apr 2021 18:06:40 +1100 From: Herbert Xu To: Kai Ye Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com Subject: Re: [PATCH 0/3] crypto: replace memset by memzero_explicit Message-ID: <20210402070640.GA10374@gondor.apana.org.au> References: <1616721648-56258-1-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1616721648-56258-1-git-send-email-yekai13@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Mar 26, 2021 at 09:20:45AM +0800, Kai Ye wrote: > use memzero_explicit instead of memset to clear sensitive data, > such as buffer or key. Does this fix a real issue? If not then it's just unnecessary churn. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt