Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1155727pxf; Fri, 2 Apr 2021 02:48:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRPfAAzIgnrC9q9+33tpDD0lEj9ZOtyb4eXpuSszjZjVQzTHvVbIeYIlV3F5JyvaZHVxQb X-Received: by 2002:a05:6638:388e:: with SMTP id b14mr12516846jav.62.1617356893690; Fri, 02 Apr 2021 02:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617356893; cv=none; d=google.com; s=arc-20160816; b=eaadew+oWh9bgpABiXZynOILTCO8j2A9yc9q0NMwXNRN88x5b0anpJ8Sfq8U9mauWJ xWmCnn4cp0EYsr4vji5G97WVadwzYP7XgBpVMVOp6iyHv0aDMzDF8LXaGtDLCAMxE8Bf dvwqTaErENhZdeVQ82fYega+j8FTkSdomVXqWAKF6MF3pbgUwE7iau0td3syuK7csbzl WazZoasW8A3H55HdY45wPCRN7AtfkNAaCqhHVQkdcCmOsGtsYJdPbUY7mH64q4CAchSb GhLQ0EIOnGs9P01uH5n8o6jXuitBa1qx/nt1lYOsHEKJlAXuNV7BUDfhtzhH0MVCLGpD JkeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=NIHBI6Yak/pQ3nSmbOWdgXnVv3hQWBgZzt9vs9EjBXw=; b=kTE1wvMNzIIRKs/V8KpRtbT0/hj86T4WrvRdsmus3u0iseQA2769WuTELR0NwxSD73 QqmW7xl4il+4fHLSPAwlB0Me6evjDjPqJgFZpqNvYnz2dwiawpJXPVJc/I8vUWpayJVK Mk0+H29Ny6W6sAgT0pUSow333efPm30SxJPPtBWA3i4k2BnakcTj/UJhCtHunDw9RjGa 17uTg9VSd1VLdt5/9y6AmPQUQ5ZyEruFCgocFB9vO6aaj9z1EMHK9jlim1DZqBxklYIU YXRncJd1v+BZw1CuBxTQS3XkUla3+BJQDZ7I9yMMCW2pNNqcfyMSwfFIfHIA9RoGABKQ 7M2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w12si7052007ilg.43.2021.04.02.02.48.00; Fri, 02 Apr 2021 02:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231160AbhDBJrz (ORCPT + 99 others); Fri, 2 Apr 2021 05:47:55 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:33720 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234275AbhDBJrz (ORCPT ); Fri, 2 Apr 2021 05:47:55 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lSGP7-0003UQ-PM; Fri, 02 Apr 2021 20:47:50 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 02 Apr 2021 20:47:49 +1100 Date: Fri, 2 Apr 2021 20:47:49 +1100 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Marco Chiappero Subject: Re: [PATCH] crypto: qat - fix error path in adf_isr_resource_alloc() Message-ID: <20210402094749.GD24509@gondor.apana.org.au> References: <20210325083418.153771-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325083418.153771-1-giovanni.cabiddu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Mar 25, 2021 at 08:34:18AM +0000, Giovanni Cabiddu wrote: > The function adf_isr_resource_alloc() is not unwinding correctly in case > of error. > This patch fixes the error paths and propagate the errors to the caller. > > Fixes: 7afa232e76ce ("crypto: qat - Intel(R) QAT DH895xcc accelerator") > Signed-off-by: Giovanni Cabiddu > Reviewed-by: Marco Chiappero > --- > drivers/crypto/qat/qat_common/adf_isr.c | 29 ++++++++++++++++++------- > 1 file changed, 21 insertions(+), 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt