Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1156602pxf; Fri, 2 Apr 2021 02:50:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVE/VHiEcEGdQrfBIb/gkiWn51bSm/YBOViFiTmwHBdMZCRMF68sNVIEcSQbd9JCpiEzXC X-Received: by 2002:a92:d483:: with SMTP id p3mr10561044ilg.28.1617357019431; Fri, 02 Apr 2021 02:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617357019; cv=none; d=google.com; s=arc-20160816; b=z/XPnQg4r7V2e52N78uMr+g5vx9cjavyvj/4rPTyhuHtP21M5GVY7meUvuufDz2NP8 rUUrrPQJQ0qdBZb1BAm2GovGYp+sHIbUuFlNDMTnjlaQJWb850H4YdldOE1hAhXDOg/s 31f4RsjTD3e1P7Ft1u2f3kiPm1DNloc2sDU4jhFzrSgV8g4k9oi0PcmZCCXDBcHMg+Pt J9yKlDjxmggk3irQ7tb+3OJj72QEiL1Ax6N4sYne6JeTR426NCBvCcGBNddt7zcS0/2v SaX9DUGhwpuYMNU+33Bu+Z2rBffa1Nx3JUoOshGUhLFiHZ+DuiSqzw4F2jDEL9bjgkC4 1tFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XurrR/iKw4Tlrt3Hj3gag+T400qr8Gg03rsO3T7BW/c=; b=aCVgu/ZH0S5ZlcMa7jczjxxVbFjy4KM+IZlCbocqcMGb0xeJ0t1jojkSuD8eE7Lwvu +V+GvRCwB1s4UiaJckIXdR6MtZ+w9kRwlF67NA/efthgl89Vw/ZXdnV3pk7WozXrkReo XYbT2EGcMHtDCSHKkRi8BCOJ+tsNvf6cjVHFS1HgrezOo1UJLgX6IzEet+99fUJI16y+ qR1vuJ7g4rOWrlAvlQogshQWCdAFp/0uQk7UFe99TDQ2MlQ+GSP8zGCtkTIndVCd5Ar/ KCcYHL5LvRFI+RLYFTBqXrXHX+CHJfPgOvDzeWCYwAuvKcmXjouVbv4pma7FvPc2tBJj WPng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si7619925ilf.36.2021.04.02.02.50.05; Fri, 02 Apr 2021 02:50:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234448AbhDBJt2 (ORCPT + 99 others); Fri, 2 Apr 2021 05:49:28 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:33826 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234217AbhDBJt2 (ORCPT ); Fri, 2 Apr 2021 05:49:28 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lSGQZ-0003b2-QM; Fri, 02 Apr 2021 20:49:20 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 02 Apr 2021 20:49:19 +1100 Date: Fri, 2 Apr 2021 20:49:19 +1100 From: Herbert Xu To: Meng Yu Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, xuzaibo@huawei.com, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: hisilicon/hpre - Add processing of src_data in 'CURVE25519' Message-ID: <20210402094919.GL24509@gondor.apana.org.au> References: <1616838976-31936-1-git-send-email-yumeng18@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1616838976-31936-1-git-send-email-yumeng18@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Mar 27, 2021 at 05:56:16PM +0800, Meng Yu wrote: > HPRE can only deal with src_data smaller than 'p' in 'CURVE25519' > algorithm, but 'rfc7748' says: > 'Implementations MUST accept non-canonical values and process them as > if they had been reduced modulo the field prime' > So we get its modulus to p, and then deal it with HPRE. > > Signed-off-by: Meng Yu > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt