Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1205578pxf; Fri, 2 Apr 2021 04:19:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgbVCygDRUxx0zhfPJqtLVptEOCwhHCZbXM62NUrvL2kfQ+cXxyTF0bXmVLSxvjMqYFHHv X-Received: by 2002:a05:6402:6c1:: with SMTP id n1mr1790439edy.158.1617362356232; Fri, 02 Apr 2021 04:19:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617362356; cv=none; d=google.com; s=arc-20160816; b=SymDZo82g24Khoyjn5wqtIJ3346NWJPSNYgpg9FNUeuDjGqEgZCUuCSM3tT4eA/qYq IRxc6JikJHAhFy3bQ+lhmBk+Lj+3vKx5OIGybRFCvxRCGwbTbr8+5cUMWFZMrGkYZUiK qdOrfUkttCpp99kYC8hMbBsgm/wXw3//BiiNfupGZg/hJAvllNBQFxWD268G3doxrLVx jM1v+lBp8dOkalDG4hnollbZN0w/x5ZC652z3DJr2I81rF1zeJTTExWc3x976LVioyzF LtDIJ1ZaJpJiOSVkGLid5XGt7lAPtC/E6g5bpfMNGYhYI148d+9UnR4zkYR9deP1+Xkz a2zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8E3SEQHWtD9oyxpVQil1WLhWIN1NJ4aU8PFyBCEE/9I=; b=xYVplc+M1x0ucgf1Q5T0sJiw8hvvmZ48GNsWD6Y0S8xjyhZnWzvCPCkCTP2DBNDkNx Xp+y7Ov0kYGI0lyGwSnT9f21kHOiJcGk06UC+WR/Y1pTswkuU0ccCdxYCirMEvV3//jB DRxGBDhb6ttvE/svkc64dBEYDttuvYYyyYgoksrfNVRHl9+feCqlAZHdZgfl3Wh5ln/h /P2c5Dv7JjCuLOo+a876BqJ8Oct9CJS7EuP4dJIkWJA/a5nyH2JBd7mAHBjA5oF/g7AH 3dFJkDa0/Qr5pt1UAzjLl1zkC44Kqg3eTKgANhxr94h7R+nfrlo0G4+DaMH3sVvQ3Tpi MraQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aqP3pMYB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b15si6023213ejv.689.2021.04.02.04.18.43; Fri, 02 Apr 2021 04:19:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aqP3pMYB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbhDBLSb (ORCPT + 99 others); Fri, 2 Apr 2021 07:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhDBLSa (ORCPT ); Fri, 2 Apr 2021 07:18:30 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5183C0613E6; Fri, 2 Apr 2021 04:18:29 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id x7so4452156wrw.10; Fri, 02 Apr 2021 04:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8E3SEQHWtD9oyxpVQil1WLhWIN1NJ4aU8PFyBCEE/9I=; b=aqP3pMYBFohRF0lJwLR9OejAloqY6YrXbLNGYs9zFLgCv1MCuHZgj+iSPTeNoGQ12w EyDaCkMvX460y0dvE3hkVfUSuIwTGfroRpBN9oog6OWB4hEKvepYFFPE+VeWXB49iqN5 dLgN+ei3rW27jDeJ26Zb4HM1zjaSGDUIkBjN6VeHlwK42H0NEhOg/oAPO2e8+hbrglCe wFD0sJQ9wmT9rP2wWgsZ7iIi1RZNQMheo6Y9xqlezW7Mq2rwjKQKT6byD+VWJGctCxw6 xZcVGeNNDgjZ3a7OBtjjVcklPFudhVTg2Az6gV3ThEHsOoJQhKaV9EFaq/PKuz/32oWj 9MzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8E3SEQHWtD9oyxpVQil1WLhWIN1NJ4aU8PFyBCEE/9I=; b=hcnk2r0+WhYsR2/SqmOJhB7UC71jcrNlKLRSblqfsrrdNW9GWG6WpZEEPWMm0JrnVN tczIh4eb/uH21tTpzwyjRqEccwb6X/jUEB6cHT+JaDgCIOtuzA/CPT3RrM2WNh8NDa1A f4N4xMHmssccsFk9AcMaC15uuquhpef/FxRNkPZblWyPHNdDOvEV9q/M+WQKVjwx1ZyU oODnpVt1EUQc2kzo5pLV0pTZIEyL6eJPBPXcaypXxrbsnIJ4FW7Jkej8njOe2ZqW0z94 BB/YxwFgtK92CJdeKo+fGPwZ8QWdpuxCpLeqahxhe0NDLWVAyF/igVoUeNDVuvDD3t1A FqIw== X-Gm-Message-State: AOAM532nOyTMTpp+ZxaNkHID8Hbo4bVM8UrO40P67EWTD+tRCEacUh1h mlX/AsPQ7l2MX+/t2Yu86QgOE16PXyo= X-Received: by 2002:adf:b345:: with SMTP id k5mr15205746wrd.14.1617362308620; Fri, 02 Apr 2021 04:18:28 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id r10sm14279138wmh.45.2021.04.02.04.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 04:18:28 -0700 (PDT) Date: Fri, 2 Apr 2021 13:18:25 +0200 From: Corentin Labbe To: Colin King Cc: Herbert Xu , "David S . Miller" , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] crypto: sun8i-ss: Fix memory leak of pad Message-ID: References: <20210401151827.2015960-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210401151827.2015960-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Le Thu, Apr 01, 2021 at 04:18:27PM +0100, Colin King a ?crit : > From: Colin Ian King > > It appears there are several failure return paths that don't seem > to be free'ing pad. Fix these. > > Addresses-Coverity: ("Resource leak") > Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") > Signed-off-by: Colin Ian King > --- Hello Acked-by: Corentin Labbe Tested-by: Corentin Labbe Tested-on: sun8i-a83t-bananapi-m3 Thanks