Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1209597pxf; Fri, 2 Apr 2021 04:25:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXsoKWGXXCOzu3p8K94A+nDlzI+WuyqEDwHzyqq7hPar7aWLoXLpMUEqe9Gq922ZacS7xD X-Received: by 2002:a17:906:4fcd:: with SMTP id i13mr2022102ejw.341.1617362736862; Fri, 02 Apr 2021 04:25:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617362736; cv=none; d=google.com; s=arc-20160816; b=m2CpmdVxxtuFr8o2Xk76rHN+ReBfLuZUSW+PD9Euycv7zAXBn8x+SfPl9HK7uP/dov oE7u6c5vuwNRAOI++cWg2GuFU/orz0IojxV5KEGL79VuMetuIAVMQ4zj2iVQEAc41s3/ H4j9tlDPDAPG01x1pszMRJz1VhHSP2yYrDdTwgu5tVuc1M2LxK3wO751RsGEW5HAk1C6 4R0sPhpNbk6e5sQHHRx/pVhMS2Bj0g5Sq4tijbcUBlOb2bF0uRE+0FmhjIf7DVU3tDOV sYAI35+9cVXTAgpCCSl1vHt9p2MQOQ9g1yDBe5/LUML8z9OLQ6GyndRKpvMteQNimcLw UtuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=nJ4oKSWEkUy9V6Bi6KX8uzmDAII/AOdqCn8sB5Eo0zM=; b=mE3ssR0KJyAlcEgCabV8zI9FPpiKu/zoEaCW6uugufRNq8vdjYtSHIlld2X8L+i0t7 ZAYcvfyLFMXkhOvZwZmjSbE5DLuPNmZpcQKvwqsbOETKRdUiSR7NNKSb1qLryDJLe6m2 wc57A7/I600Z180FQo3SUamgKjQEZbNx36EKEyFn59laKlLHSOVvUs9Cp6DZEwyR/4oS 2Mtyz1p1PGJ/aaEtlbVhdrObwM0wc9ZQYtmn1voI9yyhPAzvKzVwQYefUptknV2gFpWN 3xUiet4TkqBHE4i/3a62wYypxeixk63VWNMn0k+2YNdwGiNA9uKnp3ZcRFRLzBYpQv6j Uhmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si5984913ejg.130.2021.04.02.04.25.11; Fri, 02 Apr 2021 04:25:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbhDBLZK (ORCPT + 99 others); Fri, 2 Apr 2021 07:25:10 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15470 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbhDBLZJ (ORCPT ); Fri, 2 Apr 2021 07:25:09 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FBd2X1VRgzyNh0; Fri, 2 Apr 2021 19:23:00 +0800 (CST) Received: from huawei.com (10.67.165.24) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Fri, 2 Apr 2021 19:25:00 +0800 From: Kai Ye To: CC: , , , Subject: [PATCH v2] crypto: hisilicon/qm - delete redundant code Date: Fri, 2 Apr 2021 19:22:30 +0800 Message-ID: <1617362550-23630-1-git-send-email-yekai13@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The "qdma" is a structure variable instead of actual data. This structure doesn't need to be zerod, The memset is useless and redundant. So delete it. Signed-off-by: Kai Ye --- Changes v1 -> v2: Re-edit the description. drivers/crypto/hisilicon/qm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 13cb421..88a6c6f 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -2527,7 +2527,6 @@ void hisi_qm_uninit(struct hisi_qm *qm) hisi_qm_cache_wb(qm); dma_free_coherent(dev, qm->qdma.size, qm->qdma.va, qm->qdma.dma); - memset(&qm->qdma, 0, sizeof(qm->qdma)); } qm_irq_unregister(qm); -- 2.8.1