Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1210822pxf; Fri, 2 Apr 2021 04:27:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDc97ZURcr65z1dhXlzJSRuFS+wKP3SLUCeICSBJApQoDUv7wVt9BtIVfXPDR9/1gyWkAP X-Received: by 2002:a6b:7b05:: with SMTP id l5mr10499645iop.32.1617362853508; Fri, 02 Apr 2021 04:27:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617362853; cv=none; d=google.com; s=arc-20160816; b=0syKYkSXJDtJfYAEDfCEGhGOJFH6XSPmOKTkMbhUcy3VgJyhjt4GgwnBW48bVf3Jah eNWgVdXd2ZHZrBiAMS0ygDUoPFQtbTgdUNV5csPYuD3q9GqQqlUjhaK2qrVRHHZkRgpy +90IbcZX7BaYMbh51kSOgtKz63o4f8wpbay2regtxbJfx481HwADcwSVZxAwsQFT9AZf AngSOqlDtAdr3N2WVFylpOtwWY8Dr2p2MnSr8MfwBCO8BWq26YzJjnfGzPWkXdqZj0uy PMUOgsu24b3rBF8JxAIaHwZvGRKZxZeRaKeMHlVg38KwZKkjXiWDDMCelJONri0VZmrm YVzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=dUdAR2NZwweUwPHLEqMvUV7RnlTscnxtYKPymW2lXhg=; b=bc3niPyczH8sdxscwm/ka5f0VbncAvVC0NNrqJWLP/UQ7tkVLojsztSz8CMJRRshX7 7eEaHJIGK1uyTQDS78YsMQ3KtkppY/NT0wSRgqhdNZKNtzCG43sMpM4ct5b57s4AXSvP OfptX1Q8h9YvrkhdXoE4rf5Fhmr+rcQ1FXRFePDd+4lln4AcxfwCi+oL7z3cSegTib5u hauITYesB1ZOvItfgy+AjfCxHmMn3+vB2WWP9iMl8mRtQLx2Lni3CMMDgOGgk4rQ5LHa CITbmFkwHVLAUMbOlLS9dZGwtHKWPny69RiSOiRftV8S1XuBk9p0Rkzs3cFCjud1rIpo nhNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p31si7757256jal.19.2021.04.02.04.27.19; Fri, 02 Apr 2021 04:27:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbhDBL1P (ORCPT + 99 others); Fri, 2 Apr 2021 07:27:15 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15535 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhDBL1P (ORCPT ); Fri, 2 Apr 2021 07:27:15 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FBd4H5STPzPnYG; Fri, 2 Apr 2021 19:24:31 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 2 Apr 2021 19:27:03 +0800 From: Hui Tang To: , CC: , , , Subject: [PATCH v2] crypto: hisilicon/hpre - delete redundant log Date: Fri, 2 Apr 2021 19:24:29 +0800 Message-ID: <1617362669-40372-1-git-send-email-tanghui20@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not necessary to do it here, so remove it. Signed-off-by: Hui Tang v1 -> v2: - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero. --- drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c index c7ab06d..fa40835 100644 --- a/drivers/crypto/hisilicon/hpre/hpre_main.c +++ b/drivers/crypto/hisilicon/hpre/hpre_main.c @@ -386,7 +386,7 @@ static int hpre_set_user_domain_and_cache(struct hisi_qm *qm) if (qm->ver == QM_HW_V2) { ret = hpre_cfg_by_dsm(qm); if (ret) - dev_err(dev, "acpi_evaluate_dsm err.\n"); + return ret; disable_flr_of_bme(qm); } -- 2.8.1