Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 0/2] PSP TEE driver update and bug fixes
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>,
        John Allen <john.allen@amd.com>,
        "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        Mythri Pandeshwara krishna <mythri.pandeshwarakrishna@amd.com>,
        Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <cover.1615796554.git.Rijo-john.Thomas@amd.com>
 <20210326092919.GB12658@gondor.apana.org.au>
From:   Rijo Thomas <Rijo-john.Thomas@amd.com>
Message-ID: <8361ffb7-d4ad-1663-8b08-b0becf1835c1@amd.com>
Date:   Mon, 5 Apr 2021 12:10:00 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20210326092919.GB12658@gondor.apana.org.au>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.138.129.146] (165.204.156.251) by MAXPR01CA0099.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27 via Frontend Transport; Mon, 5 Apr 2021 06:40:12 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a2a80013-0696-45c4-e692-08d8f7fdadaf
X-MS-TrafficTypeDiagnostic: SN6PR12MB2815:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SN6PR12MB281542B9F81B463303DBD11CCF779@SN6PR12MB2815.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9MQz+PoR7KJca6qX9zggsN4c0fXaf91gVvCFEwntQwFXl4ZLbAi0kUmSwmsuB1aWXvdR8ZTNRzviwryGW+/YleaSlD314WrN1AiRX6haaXcmmhUcE5RJSzYly/06sWSWcivbWmw5CamyPh7PwJzfvnzFY5DYZY98zbLibUf8wU0DR/vFWg701Z1Uvj2Cm5IT9FVestC3blNbnFDf/Up7RpzQIQg60K5/WSKePjzv1VP6GtX0ubU+yWKDTauxFV2pO9OgABb/HqVf82mEpmTIbyi0XZSQp563aMSD9sr2pTHJuhWqUO1u9DzZ8W1/6xBy/u7ssDp5Jxknb2H4DiRc0STf+G3Wikp8vlHlgSJnSKRwlxVKepdNo1FkQoUk6aJmtgOoDVkgDFPqVB8NXzg3lKXV+Ee4XQiqPIHIzT0OJjFE0UHFs+RST8QdPKJP9zQb32dVdyi25rQ2h5ynThIcvB9unjegnK/QPHQG+WN1J4J8QRJSvnwPwLfRz44VsGRCGuOL+pTILhjouquZEVHT6gWxlM1P1j6cHhmQjnnl3ZdswVcFe0GZW+1e5ADhjap4PKaDPbtMtcwCQLt5e+9ibJO/sFB/aDzrl6ZiODndnZLUfs+VtyD9KS+iL54q26yCMnUiMJGDu81EXivwWfEl+LD666Eozg7osU5btQiXvER3ab35oKDJGCRwZ80WSTji3p06yTcOVW2LTakh1zmf2w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB4719.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(346002)(366004)(396003)(39860400002)(8676002)(8936002)(66556008)(66476007)(2616005)(66946007)(16526019)(86362001)(26005)(5660300002)(186003)(15650500001)(31686004)(54906003)(31696002)(38100700001)(6666004)(53546011)(83380400001)(52116002)(36756003)(6486002)(478600001)(4744005)(956004)(4326008)(6916009)(2906002)(16576012)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NWU0aEZnaEJrMEFiMGttYVBpS0VJWTFtTmMrYWpndjI4L0V2NWhnb0daSWlX?=
 =?utf-8?B?WEhVeDNiUHNNenJkSHR1Z1cyU1BVZzR6b05oN3ZSK2xmUUp6c3VzSmxlRFpo?=
 =?utf-8?B?NzJ0aDRDekpxZ3RrU3dQMCt0YTRYS0Rlcy9yYUJvYlk2TjFyVEp3RXNWaEp3?=
 =?utf-8?B?dmNrY2VWZnIzRlVxbTlLVlhxaVQrSlZwaUtYZXorUEhQL0NpNXZxeWlYMG1x?=
 =?utf-8?B?VkN3WDY2QTRVY2xYSU51b3M1aWRYd1IwOXhtZThIV201eS9pL3NUQVRWdHNS?=
 =?utf-8?B?Q1VBVjNHcnhnZHpqUG1YMGVxV09Ic1VKd3dQVlpPWE9YSVdtbHk4VE9IdzJL?=
 =?utf-8?B?VktZYmVuUFQ1SXpIMXRjMG0yYWdqcWJUNHl6RDJJdk1vMDhaeFNrTlZ0eitL?=
 =?utf-8?B?R3QvZGFCUHFPajdaVXdUREFhc21TMTNOYWhWYTRSS2puajVkei85S1g3RUlQ?=
 =?utf-8?B?dm4xNmRFSy8rRkZpdnpETXMxN21vWi85MzFsQmlDR2JNbVNiUTVSRjJINVJt?=
 =?utf-8?B?RzdyV1JMaysrSXlCbXhQdlN2L09nSCtJOExTaitBWDBkQm1MSXB2WldZTEI2?=
 =?utf-8?B?Rjhpa1FMZTY2L3dmT0hMekFFTHJwNUZBQ1paczlDQndweXVsa2JGSnEvZkt0?=
 =?utf-8?B?dUtDeWNDZERkMFE1LytBUXRCc3ZxT2l2anlPV3htTiszQWVocmNBdTV2WGJ2?=
 =?utf-8?B?MFB4SFFRY1l6YzdLQ2FBVDlTMUFSbGEvZW9LK1lZcG02RlhxeFJVRmtCdzFn?=
 =?utf-8?B?b3liRU5Cdi9wbE1oY1BlSllwTmhkVGlkbWdPSnRuTGdEUHlSdVlSUXAzblVo?=
 =?utf-8?B?d3F6N1FseU4vc1JYYUhFVHRaTTZzU2pPby9wd2syTXJmQUhnZ2gydUEwN0hs?=
 =?utf-8?B?MHp3bmpNbC9wNmQyeUpYVnJjNUhYZjc3MDhrSnYrVmcrUXoyS2QyK0FDUUow?=
 =?utf-8?B?VWhMRFJONHg1U0xGZFZZUmY5NUJFa2xITXhrTGw5SHRqVTMyYVFMUE1RRHhG?=
 =?utf-8?B?VmdxTnkxQmJGTC84VTN1Wm5scC9qU3VMb2ttdk5aNEpDNzVRNGtQc1AyQmVB?=
 =?utf-8?B?bWl0d3lmN1MxS1JML0lyTlc5bjduem9Bb0cxNjdadm55c3VGZWkweG1aMU1j?=
 =?utf-8?B?WS9FdWlRQkZySWRGekJYMHRqcEVuNkJUMndRY05TTG10NkRjMEkrenhhYVhK?=
 =?utf-8?B?SnplZkJISS8zek1oeFErM2NDU00vMmZObzFFa1JSUzFLTGs0Rm1VaU1CS2VR?=
 =?utf-8?B?TC80TFJUMFNiaTZMdnQ0K2tnem9HbVF4N01ieTh3T0lCY2tHUWxVNms0ME1z?=
 =?utf-8?B?YUMra2JmZXBCQk9oRThmQjZSL3dsTU03bytPc2xpN01saDJ2VW9DTVR0TU5S?=
 =?utf-8?B?RUpxZ1pIaGNVNmlqVDE0QUJPdmVMQ1JKYUVUc3k2RHBrK0NLZEptd2FnZDZQ?=
 =?utf-8?B?akpWYmhDRnFyN0psc2xWMndKTS9Bd2dRSE9FcnlubmFSQ1BpSmVvOEtjVW9h?=
 =?utf-8?B?SVkyaktHTEJnYlFSZXBHMWVkazNjQjdvUE43L3duSDlSRm9tMU1uQmVDSk0x?=
 =?utf-8?B?T1luc0pWMDZXZnRZd0dUSTRiWjBPbHhKd20rbHZqcStLcUxPbkxOazVoNlBL?=
 =?utf-8?B?TmJyVndRNUxPQlBkQk9oRmJqTUh3Z0F2akdvYjJYV3RUZU1mc1dWd0J6a0Uw?=
 =?utf-8?B?MWRoRXgxQ1ZOZU42OTBZNTdNZHRoNm5yU1VvVUg3a3NQdlBjOGU4eGFVclRn?=
 =?utf-8?Q?B1Iw0zHBOPm/uW7pwkHS2aAjSsbN5LajQiuR6yM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2a80013-0696-45c4-e692-08d8f7fdadaf
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB4719.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2021 06:40:18.7926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wq7sW5mCUZm0ek8b94y+amrbbfEDWOSLgc8WJstITAO5HKGu0058ILu0nRh4992F+HGhg11yfBorDTe3WAcSEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2815
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 26/03/21 2:59 pm, Herbert Xu wrote:
> On Mon, Mar 15, 2021 at 01:55:27PM +0530, Rijo Thomas wrote:
>> The first patch helps to improve the response time by reducing the
>> polling time of the tee command status variable.
>>
>> Second patch is a bug fix to handle multi-threaded use-case.
>> During testing, race condition was seen due to missing synchronisation
>> in writes to the TEE ring buffer. This patch helps to resolve that.
>>
>> v3:
>>  * Fixed checkpatch.pl warning
>>
>> v2:
>>  * Updated copyright year as a part of code change
>>
>> Rijo Thomas (2):
>>   crypto: ccp - reduce tee command status polling interval from 5ms to
>>     1ms
>>   crypto: ccp - fix command queuing to TEE ring buffer
>>
>>  drivers/crypto/ccp/tee-dev.c | 57 ++++++++++++++++++++++++------------
>>  drivers/crypto/ccp/tee-dev.h | 20 +++++++++++--
>>  2 files changed, 57 insertions(+), 20 deletions(-)
> 
> All applied.  Thanks.
> 

Thanks for pulling in the changes.

Cheers,
Rijo