Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp881303pxf; Wed, 7 Apr 2021 14:02:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8WZrxfn/eKuvdWcLPBZbPv6S+Sdui6BVev8JekHbBlTiFCmdMdDWn3vBhFq/uk3pI3CxV X-Received: by 2002:a6b:7a4d:: with SMTP id k13mr4136158iop.39.1617829378820; Wed, 07 Apr 2021 14:02:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617829378; cv=none; d=google.com; s=arc-20160816; b=DqPytwBSnaUUtWXDq9+kJ6AKaQkDDCQ4r4FV7frZGRBnWm9HJsHDjbPdZE71DdJH9g CPfa6Mgfix0ZXXRV3DQZJbjMDsi/0/mM8qefyGPSPLHZaA62F0a8+j820yLc9H6vmjI2 qwBrg/VbHmz7/IM2NiITiHEljvrZSP41A8hCQvQmshnSfUDSW5zLrlMB4OYm1mjZiyom aUbF/o8YaMCVEbiZk2YOSS2gxM99lfHmoNDdZudQRp2r56tTCswwa3f7N7j3Yn+OIWH+ BgLmg5ZDD+3iifMwuS7cyCYjFhKArebo2jTtiQFPi+aPXwBPHhUZ6b9920TKT8R/a6HF 9VXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=eH7qAHgn7Iw54l7CRDjhThqAevwXxpA+10a/LNb/GQo=; b=tJlhZo+WOWcDpeRskma/P4zAyPXbf3tnhtehieek+ofL56J/wfHBplfV3ZGNGsAqBB XFjvF0NYhKIYtGcdo4aHxnFOhtK/NDC1OTz1x+7tVj79/TMZxLigyqTKJ+jOmmJvyDqP 2aBarEaBEpN0L4xGriT+96AjXW5LpJjUNev7OxEJb804Q1hmXORvddRvEgK/K2B7n3Mh yJCLA/M3EwC3UYGBF5SWGVWb8lGQ4zLGiuV69qzou4kRVWi1gY8RZmxaWYQ2Lns57xmG W5t89YrqiBEARWxf4r7H3mnoE1Lp1oH1JMm6lJJ64zy69SW+3OJlAqW0WKvD5ZSV3w/3 QRIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k31si22973050jav.116.2021.04.07.14.02.44; Wed, 07 Apr 2021 14:02:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348176AbhDGOSs (ORCPT + 99 others); Wed, 7 Apr 2021 10:18:48 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16815 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232885AbhDGOSs (ORCPT ); Wed, 7 Apr 2021 10:18:48 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FFmfK3gNhz941H; Wed, 7 Apr 2021 22:16:25 +0800 (CST) Received: from localhost (10.174.179.96) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 22:18:30 +0800 From: YueHaibing To: , CC: , , , YueHaibing Subject: [PATCH -next 4/5] crypto: keembay - Remove redundant dev_err calls Date: Wed, 7 Apr 2021 22:18:18 +0800 Message-ID: <20210407141819.32588-5-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 In-Reply-To: <20210407141819.32588-1-yuehaibing@huawei.com> References: <20210407141819.32588-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.96] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: YueHaibing --- drivers/crypto/keembay/keembay-ocs-aes-core.c | 4 +--- drivers/crypto/keembay/keembay-ocs-hcu-core.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/keembay/keembay-ocs-aes-core.c b/drivers/crypto/keembay/keembay-ocs-aes-core.c index 2ef312866338..e2a39fdaf623 100644 --- a/drivers/crypto/keembay/keembay-ocs-aes-core.c +++ b/drivers/crypto/keembay/keembay-ocs-aes-core.c @@ -1623,10 +1623,8 @@ static int kmb_ocs_aes_probe(struct platform_device *pdev) } aes_dev->base_reg = devm_ioremap_resource(&pdev->dev, aes_mem); - if (IS_ERR(aes_dev->base_reg)) { - dev_err(dev, "Failed to get base address\n"); + if (IS_ERR(aes_dev->base_reg)) return PTR_ERR(aes_dev->base_reg); - } /* Get and request IRQ */ aes_dev->irq = platform_get_irq(pdev, 0); diff --git a/drivers/crypto/keembay/keembay-ocs-hcu-core.c b/drivers/crypto/keembay/keembay-ocs-hcu-core.c index 322c51a6936f..0379dbf32a4c 100644 --- a/drivers/crypto/keembay/keembay-ocs-hcu-core.c +++ b/drivers/crypto/keembay/keembay-ocs-hcu-core.c @@ -1192,10 +1192,8 @@ static int kmb_ocs_hcu_probe(struct platform_device *pdev) } hcu_dev->io_base = devm_ioremap_resource(dev, hcu_mem); - if (IS_ERR(hcu_dev->io_base)) { - dev_err(dev, "Could not io-remap mem resource.\n"); + if (IS_ERR(hcu_dev->io_base)) return PTR_ERR(hcu_dev->io_base); - } init_completion(&hcu_dev->irq_done); -- 2.17.1