Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp906133pxf; Wed, 7 Apr 2021 14:42:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6R+bdicRp4GQphffd+LSM7+FPxpknDGZdt04aDyYROyTTe4nCY4263PdxvYrYcxHZCJAA X-Received: by 2002:a62:ee09:0:b029:211:1113:2e7c with SMTP id e9-20020a62ee090000b029021111132e7cmr4569067pfi.49.1617831766387; Wed, 07 Apr 2021 14:42:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617831766; cv=none; d=google.com; s=arc-20160816; b=h5FPb8BlwjFz5S3uCqhJu77y7fZHGCzE3Om59c3TiBatp7tGycQg1qduGPyrGVtMQ2 XKslnIbrY/c89JPcJw1oRp3yUH1GBk4NqtNx1O3Qplq4Qwy2wNJsLLmbkcLj9n5NL3nP AJhlwyL3AywyFbxJ8msQQT0Uwgn0U3fmnI4LsPv6FsoOGGwQCXEQ9VnstJwLrXXHZsT3 0jEvuDIHcRCZ63GR+YXLZZny2CXe3i10qGOJoV31nTjrpZiFfmZOuGTEBWlwyf0ixuww qUTlarLl7V5wkXfjkgzepqxxoAdlIkldo7qQx32GvhKH1GCeSxDuiFnVwRQOYjkQicoi pS2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=sUkYM7WCCXKnwg/zUvOfD4pBnanjqPIlkGqAYPeOayY=; b=nAi6xgwlTZ71ECwF92H7fuLX4fBONLvSFh8fbxqn6Ns/fkZWZKrJOmyyoWDcnLPXdD qcJ82vywdtJK95rJa/Nk1V4j1Id+3OYZozbYY+68ZHJDUy6DRsL4o3OKFW6Q+8yQFKdw xI2gFFRGqeOuRpgdO/F/JaKjmzHweef/Xyp4IKZHtWmGMyT830n7nqNptqmgZBJZWEWW VMvHP8S/RMrTQPa4ChSCKMreagHh5oLYmayN6rGqpQpMvgfMfcn51Wrstqn8yhdwdQlq bABvkFFTXZE4BcwX2i6LcGgzrH5wJIy5uoBEWBAJdM80p/bo7naW4fLBshNltcwQ43Bu Df3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 34si13252867plf.51.2021.04.07.14.42.33; Wed, 07 Apr 2021 14:42:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354774AbhDGRUC (ORCPT + 99 others); Wed, 7 Apr 2021 13:20:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354763AbhDGRUB (ORCPT ); Wed, 7 Apr 2021 13:20:01 -0400 Received: from smtp-8fab.mail.infomaniak.ch (smtp-8fab.mail.infomaniak.ch [IPv6:2001:1600:3:17::8fab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63B4FC06175F for ; Wed, 7 Apr 2021 10:19:49 -0700 (PDT) Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4FFrjv6HTZzMqFPy; Wed, 7 Apr 2021 19:19:47 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4FFrjs34sYzlppyr; Wed, 7 Apr 2021 19:19:45 +0200 (CEST) Subject: Re: [PATCH v7 0/5] Enable root to update the blacklist keyring To: David Howells , Jarkko Sakkinen Cc: "David S . Miller" , Eric Snowberg , Herbert Xu , James Morris , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , Mimi Zohar , "Serge E . Hallyn" , Tyler Hicks , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, David Woodhouse References: <20210312171232.2681989-1-mic@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <52f54ebb-6ac7-4d68-f97a-74219ed88d0b@digikod.net> Date: Wed, 7 Apr 2021 19:21:30 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: <20210312171232.2681989-1-mic@digikod.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi David and Jarkko, What is the status of this patchset? Could someone take it to -next? Regards, Mickaël On 12/03/2021 18:12, Mickaël Salaün wrote: > This new patch series is a rebase on David Howells's and Eric Snowberg's > keys-cve-2020-26541-v3. > > I successfully tested this patch series with the 186 entries from > https://uefi.org/sites/default/files/resources/dbxupdate_x64.bin (184 > binary hashes and 2 certificates). > > The goal of these patches is to add a new configuration option to enable the > root user to load signed keys in the blacklist keyring. This keyring is useful > to "untrust" certificates or files. Enabling to safely update this keyring > without recompiling the kernel makes it more usable. > > This can be applied on top of David Howells's keys-cve-2020-26541-branch: > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-cve-2020-26541-branch > > Previous patch series: > https://lore.kernel.org/lkml/20210210120410.471693-1-mic@digikod.net/ > > Regards, > > Mickaël Salaün (5): > tools/certs: Add print-cert-tbs-hash.sh > certs: Check that builtin blacklist hashes are valid > certs: Make blacklist_vet_description() more strict > certs: Factor out the blacklist hash creation > certs: Allow root user to append signed hashes to the blacklist > keyring > > MAINTAINERS | 2 + > certs/.gitignore | 1 + > certs/Kconfig | 17 +- > certs/Makefile | 17 +- > certs/blacklist.c | 218 ++++++++++++++---- > crypto/asymmetric_keys/x509_public_key.c | 3 +- > include/keys/system_keyring.h | 14 +- > scripts/check-blacklist-hashes.awk | 37 +++ > .../platform_certs/keyring_handler.c | 26 +-- > tools/certs/print-cert-tbs-hash.sh | 91 ++++++++ > 10 files changed, 346 insertions(+), 80 deletions(-) > create mode 100755 scripts/check-blacklist-hashes.awk > create mode 100755 tools/certs/print-cert-tbs-hash.sh > > > base-commit: ebd9c2ae369a45bdd9f8615484db09be58fc242b >