Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 10:11:21 +0800
From:   Hangbin Liu <liuhangbin@gmail.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     netdev@vger.kernel.org, "Jason A . Donenfeld" <Jason@zx2c4.com>,
        Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Ondrej Mosnacek <omosnace@redhat.com>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode
Message-ID: <20210409021121.GK2900@Leo-laptop-t470s>
References: <20210407113920.3735505-1-liuhangbin@gmail.com>
 <YG4gO15Q2CzTwlO7@quark.localdomain>
 <20210408010640.GH2900@Leo-laptop-t470s>
 <20210408115808.GJ2900@Leo-laptop-t470s>
 <YG8dJpEEWP3PxUIm@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YG8dJpEEWP3PxUIm@sol.localdomain>
Precedence: bulk

On Thu, Apr 08, 2021 at 08:11:34AM -0700, Eric Biggers wrote:
> On Thu, Apr 08, 2021 at 07:58:08PM +0800, Hangbin Liu wrote:
> > On Thu, Apr 08, 2021 at 09:06:52AM +0800, Hangbin Liu wrote:
> > > > Also, couldn't you just consider WireGuard to be outside your FIPS module
> > > > boundary, which would remove it from the scope of the certification?
> > > > 
> > > > And how do you handle all the other places in the kernel that use ChaCha20 and
> > > > SipHash?  For example, drivers/char/random.c?
> > > 
> > > Good question, I will check it and reply to you later.
> > 
> > I just read the code. The drivers/char/random.c do has some fips specific
> > parts(seems not related to crypto). After commit e192be9d9a30 ("random: replace
> > non-blocking pool with a Chacha20-based CRNG") we moved part of chacha code to
> > lib/chacha20.c and make that code out of control.
> > 
> So you are saying that you removed drivers/char/random.c and lib/chacha20.c from
> your FIPS module boundary?  Why not do the same for WireGuard?

No, I mean this looks like a bug (using not allowed crypto in FIPS mode) and
we should fix it.

Thanks
Hangbin