Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1136093pxf; Fri, 9 Apr 2021 00:28:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2jlrbbSmLIcoKquPcLxHAhUtZ0uGJgveG7Ao8Yp7qfNjeTLrSmrsqVLhiu/gXoPU7G2X0 X-Received: by 2002:a17:906:1784:: with SMTP id t4mr12525504eje.167.1617953301130; Fri, 09 Apr 2021 00:28:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617953301; cv=none; d=google.com; s=arc-20160816; b=Lt9DtgbxCMeCWMCkaZJUea9O9nLt905HDiDoG54AeXCOazzUCQwxBNEsg1QPaXybWG mro8F+MJyy+3s1O6k32UgfP/xSV3LWUM75kKwZaGO2sNvsXgJpWlyPQiKH693ch8sLKS c763lV/d9eMV0dVoLCWFPu57UvFNInzbMkwv9EXXqCK+doAULTc/yamLVGOvBVufFcIU RJsE4skVe8eGPB7m/YMYWI9pS3pylzWNlPAFCYV+pMycC7PxGGiJzKGl5cAblJHXcTLZ KhvT6Mo+FIQ9rfa2ihuVLr2mxWwSTvncQHlt/gcDbVH7BnoWJcJiygC2wVPgpHjeP8dZ xG2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=+xWrBBje5YFLVPAHh+VBfHRL6LwvaSQNeQ+DtQ14KMk=; b=rykYbxPFsbvzXHRrIij1M0ewIDMwuaStdkLQZqymPs5nNFKENqlpAjkR1Pj30RuFLK T7e3XRYh2S/xjQaN4gAgQ10Em3l6xxehE+jb6GYAz4Z5VyMKOJS4jzIVp1Lhj413R5IX RtW7IoepdBrVUHgOvYZtNka2H+ctaatUwCqGXMJWgR3fb8L+OBWG/DOBBCnislRoRrL2 s7/K/RCE2jVZVyp/tazi2LRO5HZzDWP9XXEvAjiCFwVSZjAPNxMnf521d5vlMTTWG1c9 pmnP3Q3Ie8V2ISoas0cBux8lDjD0+Je2+V+MaHrs0teTZ82BsM6hbwA0t85QTjaakSBc /diQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w6si1359018eje.57.2021.04.09.00.27.55; Fri, 09 Apr 2021 00:28:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbhDIH1t (ORCPT + 99 others); Fri, 9 Apr 2021 03:27:49 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:51698 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbhDIH1t (ORCPT ); Fri, 9 Apr 2021 03:27:49 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lUlY8-0005s2-Uv; Fri, 09 Apr 2021 17:27:30 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 09 Apr 2021 17:27:28 +1000 Date: Fri, 9 Apr 2021 17:27:28 +1000 From: Herbert Xu To: Zhiqi Song Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com, fanghao11@huawei.com, prime.zeng@hisilicon.com Subject: Re: [PATCH] crypto: api - fix coding style Message-ID: <20210409072728.GA23134@gondor.apana.org.au> References: <1617261649-35947-1-git-send-email-songzhiqi1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617261649-35947-1-git-send-email-songzhiqi1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 01, 2021 at 03:20:49PM +0800, Zhiqi Song wrote: > Fixed following checkpatch error: > - do not use assignment in if condition > Fixed following checkpatch warning: > - prefer strscpy over strlcpy > - delete repeated word > > Signed-off-by: Zhiqi Song > --- > crypto/api.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) Please don't mix unrelated changes in a single patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt