Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1136271pxf; Fri, 9 Apr 2021 00:28:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPVaBX5refMsDCO9gINcNz32pQ99vb3P27ZhIrvX/hrbnX4yyXNGV/LLhVi9pzmxmhJsag X-Received: by 2002:a17:902:be0c:b029:e6:f007:71d with SMTP id r12-20020a170902be0cb02900e6f007071dmr11838990pls.15.1617953327776; Fri, 09 Apr 2021 00:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617953327; cv=none; d=google.com; s=arc-20160816; b=rMB9xJmGxWyMSHD5mpCXUk2xMypXLO4E8aggPYpdZkJjSA2ZyF9kpLHyrStRZafBac eMU0EWyukOGDI2PjJ6hp8JmRC2TFtDzHwFfO+Va2OV9wqtEmWQLy8B5T8/cvCIdR+LC/ QLA4pKEcud8Jk5aCW+LMu+G12RPwU7qCtIYr4IHz4epZUnoehCcwen3ovr2UQvxCdCJ7 RDjqnVABX+u9Gi42t2skc3AHsbD1BQdjw7Yh+hSAnz6+Erz+CHN+auSsdTqnKsWYZvpe WpgoTo3xbj1l0jzsPPmC1etv+Bt6v9brC+PB6chkqnETyzynxDCSTnuoIRftIEmkD65b Tz4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=aFG1sJQYB5HUH5NAckyMP0VUhjjT4r8JTeGtBbRax0g=; b=iyJ+KeXjU0XOmNmo8LR+L5hkUjuPE2fmapc99NEBR9NRPWq2Z27QB+BDzWLdENyYh/ oHKXKgw8wqzM+5hvlQarxi5DRIY/weqTLpxHwWPC6XWW2LWrKOb30zEGKzF1ZU3FvOC2 23seCKmmfENLGaiJuXOjZNyK+7F3OImsOOAHofqFC8XLkICBbNPgGAhebTmdbJYvJPuw BIu721xIWg7UxY4ebUYSTLH3MwdeUb56/2TAt7LvdWS+9vfm4QHqkRBR9V6KNcsq7Kph rKH6ZqVrMQnOEjGN+QbI5kjMkJmfOyn1cJ1tZ4BUx5WD4kpfdlFDlgccSBXwC8Qz2ziA 44lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si2123124pfu.44.2021.04.09.00.28.34; Fri, 09 Apr 2021 00:28:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbhDIH2k (ORCPT + 99 others); Fri, 9 Apr 2021 03:28:40 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:51714 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbhDIH2j (ORCPT ); Fri, 9 Apr 2021 03:28:39 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lUlZ2-0005st-D2; Fri, 09 Apr 2021 17:28:25 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 09 Apr 2021 17:28:24 +1000 Date: Fri, 9 Apr 2021 17:28:24 +1000 From: Herbert Xu To: Zhiqi Song Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com, fanghao11@huawei.com, prime.zeng@hisilicon.com Subject: Re: [PATCH] crypto: cbc - fix coding style Message-ID: <20210409072824.GB23134@gondor.apana.org.au> References: <1617262301-47010-1-git-send-email-songzhiqi1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617262301-47010-1-git-send-email-songzhiqi1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 01, 2021 at 03:31:41PM +0800, Zhiqi Song wrote: > Fixed following checkpatch error: > - do not use assignment in if condition > > Signed-off-by: Zhiqi Song > --- > crypto/cbc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch does not appear to improve the code. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt