Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1148452pxf; Fri, 9 Apr 2021 00:55:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYU9okJTInlQPgFglVuEoCJ65vFJZXC4XrHAPw0Sf1OICEXtiAQAV+1b7lgRfblZshQ5GX X-Received: by 2002:a17:906:c301:: with SMTP id s1mr14665366ejz.382.1617954902517; Fri, 09 Apr 2021 00:55:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617954902; cv=none; d=google.com; s=arc-20160816; b=M2xTmQjO5v0aYZDsc6ebJDB/mjnJ4eWXVSGk6shrRL8mxFpidadZYKFYVl/OjUHQwa AYQ1mW20fio7LUDBJzy2hStUaSycr7eGYQn8Ip/RjfmSbkYjv/tYEiuDROKyB7sRfxNM I7df+b1rLhYubDZvYheC/Wv6+QILTU2SvesQlGBDwkfZbH83P/XVapCzEKaG/NcmvkaK GVV2zYVBlSZa3kRbya/DFzQc56znTBbkzadMx5cG55d2aSQd3I85aecrNH7uBbQjkYS1 NE3E6kJl6lDSumtFpPkRiNd/YZo/ixWRmffZKZEtoIaCMXn1YZEh20RfjIfHdxVRNrfz T6cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=AbLe3X8PxBUn6TFOaLBwg03VgB5Wn0In4XwY0SXW9Q8=; b=DrywKPnYLmdZ11j9GebCge3+ACKBtBM6odGIB1/pGJs6hiK4BSm1BM+WOzjZjozKsn JgtDwyzhYXaBKRY0rZA2S2EbVCCMPwymeac4KLK+OdbHl7f2M1npKMqOzmhbOqEFJ1+3 xqAgGCEueeOka0lmWtlu2dMjQUYc6JWeSvnQImvqMFcoL+JRGcHbGpw//LcRCC2Ulkb7 CNmEK2bPkZHoshHdhJ7c2h/hCjT9OyuTcrYxBmPSNFbtejMNaP8tLmbnzb7gLLKxYMLq YexqnuNdyUf2Jlch+h17IGiYJuwayZpGAP3ma6H9bISaFsuadqtTNwWe/+9KuunlwsI9 K1UA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si1833796edd.384.2021.04.09.00.54.39; Fri, 09 Apr 2021 00:55:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231782AbhDIHyk (ORCPT + 99 others); Fri, 9 Apr 2021 03:54:40 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:52074 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbhDIHyj (ORCPT ); Fri, 9 Apr 2021 03:54:39 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lUly1-0006LP-JY; Fri, 09 Apr 2021 17:54:14 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 09 Apr 2021 17:54:13 +1000 Date: Fri, 9 Apr 2021 17:54:13 +1000 From: Herbert Xu To: Colin King Cc: Corentin Labbe , "David S . Miller" , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] crypto: sun8i-ss: Fix memory leak of pad Message-ID: <20210409075413.GH31447@gondor.apana.org.au> References: <20210401151827.2015960-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401151827.2015960-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 01, 2021 at 04:18:27PM +0100, Colin King wrote: > From: Colin Ian King > > It appears there are several failure return paths that don't seem > to be free'ing pad. Fix these. > > Addresses-Coverity: ("Resource leak") > Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") > Signed-off-by: Colin Ian King > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt