Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1148678pxf; Fri, 9 Apr 2021 00:55:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzulmSgSES3moijOBxVqjimu06gaecf+0YqgxDuTBoDoSWNJpJKt8beqv70bvz/AvsNNdYg X-Received: by 2002:a17:906:524f:: with SMTP id y15mr14803046ejm.65.1617954929480; Fri, 09 Apr 2021 00:55:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617954929; cv=none; d=google.com; s=arc-20160816; b=fQenYYYStcODPeWvayuA85z4XSZQKQeUcWFE9r81E/2dBpnECDwZYSfmz0pIthXF+s z2su+SZrBMyBha/F6kzjDbOerAXWqr92yJTvqXpOfBqP+SPLHxvYGg9iTof7XUnUg9KW dd573B3POpo7BHKUjaxFz9k07D+aaosVxyU6QA3e5F3feacKhKGU4++e1afJdSqAzN9X P7KbC9XsgvRWQsYS08l6amPZ31LJNNraN7kvAjmBj0BxNqIKp1xF4hs3JaWYsDMOgz/E Twb5IJ4uYmHANw0aWpDo1j8Oy2pN+nxeHLFc6d0AgzpCQuR3PWBD/zCv52rk/2f8N4JL /7Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=upxcEhzWoG8mY+i+yxbaGbHWrAUuDFv59tencCcmFpI=; b=xZslAWieP7fFhrTwDVyY4oP0Y0UfVUFoKBEM/p0pxuirwVJoYxeKVX8H1FePY1Hsbm iOv42RwVUU90jQEx+KmDHZXeCzQ2eo78xC62F9MF1Q42jxXQoNN+Jm0fWANoLSMOG8zQ SBhDDcmo67/5t0NGkb6uwZclEHyDDv8KcNcviNxSnee1dSOluib0s7A1IySipbpoKeoV 7PDlWpYAFfllOkVYRbS1YCzTRLHDFOkhwRpUJdYwCp5Y7n+YoNeCYGzKs/xk3bXEUwmQ Sm33D+g5FA1dkoYNxE1/MrHq5T5vjnFVjnKZL6vbiwD9HpTJnwzTKVH5eiYCInIzI2rt qWPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt15si1625939ejc.66.2021.04.09.00.55.06; Fri, 09 Apr 2021 00:55:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232213AbhDIHyq (ORCPT + 99 others); Fri, 9 Apr 2021 03:54:46 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:52084 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231952AbhDIHyn (ORCPT ); Fri, 9 Apr 2021 03:54:43 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lUlyD-0006Lt-Cs; Fri, 09 Apr 2021 17:54:26 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 09 Apr 2021 17:54:25 +1000 Date: Fri, 9 Apr 2021 17:54:25 +1000 From: Herbert Xu To: Colin King Cc: "David S . Miller" , Peter Ujfalusi , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] crypto: sa2ul: Fix memory leak of rxd Message-ID: <20210409075425.GI31447@gondor.apana.org.au> References: <20210401152839.2016363-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401152839.2016363-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 01, 2021 at 04:28:39PM +0100, Colin King wrote: > From: Colin Ian King > > There are two error return paths that are not freeing rxd and causing > memory leaks. Fix these. > > Addresses-Coverity: ("Resource leak") > Fixes: 00c9211f60db ("crypto: sa2ul - Fix DMA mapping API usage") > Signed-off-by: Colin Ian King > --- > > V2: Fix typo in $SUBJECT > > --- > drivers/crypto/sa2ul.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt