Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log
To:     Herbert Xu <herbert@gondor.apana.org.au>
References: <1617362669-40372-1-git-send-email-tanghui20@huawei.com>
 <20210409073334.GC23134@gondor.apana.org.au>
CC:     <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
        <xuzaibo@huawei.com>, <wangzhou1@hisilicon.com>,
        <linux-kernel@vger.kernel.org>
From:   Hui Tang <tanghui20@huawei.com>
Message-ID: <b91fbd1e-0d4c-c0db-d879-3c661ad26a50@huawei.com>
Date:   Fri, 9 Apr 2021 17:30:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20210409073334.GC23134@gondor.apana.org.au>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/4/9 15:33, Herbert Xu wrote:
> On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote:
>> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
>> necessary to do it here, so remove it.
>>
>> Signed-off-by: Hui Tang <tanghui20@huawei.com>
>>
>> v1 -> v2:
>> - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero.
>> ---
>>  drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Your patch description is misleading as the patch does moe than
> just remove the redundant printk.  Please rephrase so that it is
> clear that the patch is in fact changing behaviour.

Okay, I will fix it in next version.
>