Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/7] crypto: qce: common: Add MAC failed error checking
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        ebiggers@google.com, ardb@kernel.org, sivaprak@codeaurora.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210225182716.1402449-1-thara.gopinath@linaro.org>
 <20210225182716.1402449-2-thara.gopinath@linaro.org>
 <20210405173600.GZ904837@yoga>
From:   Thara Gopinath <thara.gopinath@linaro.org>
Message-ID: <1c3523d6-ac4d-f0b7-ad89-724ed1e4f485@linaro.org>
Date:   Tue, 13 Apr 2021 15:28:22 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210405173600.GZ904837@yoga>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Bjorn,

Thanks for the reviews.
I realized that I had these replies in my draft for a while and forgot 
to send them!

On 4/5/21 1:36 PM, Bjorn Andersson wrote:
> On Thu 25 Feb 12:27 CST 2021, Thara Gopinath wrote:
> 
>> MAC_FAILED gets set in the status register if authenthication fails
>> for ccm algorithms(during decryption). Add support to catch and flag
>> this error.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>>   drivers/crypto/qce/common.c | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c
>> index dceb9579d87a..7c3cb483749e 100644
>> --- a/drivers/crypto/qce/common.c
>> +++ b/drivers/crypto/qce/common.c
>> @@ -403,7 +403,8 @@ int qce_start(struct crypto_async_request *async_req, u32 type)
>>   }
>>   
>>   #define STATUS_ERRORS	\
>> -		(BIT(SW_ERR_SHIFT) | BIT(AXI_ERR_SHIFT) | BIT(HSD_ERR_SHIFT))
>> +		(BIT(SW_ERR_SHIFT) | BIT(AXI_ERR_SHIFT) |	\
>> +		 BIT(HSD_ERR_SHIFT) | BIT(MAC_FAILED_SHIFT))
>>   
>>   int qce_check_status(struct qce_device *qce, u32 *status)
>>   {
>> @@ -417,8 +418,12 @@ int qce_check_status(struct qce_device *qce, u32 *status)
>>   	 * use result_status from result dump the result_status needs to be byte
>>   	 * swapped, since we set the device to little endian.
>>   	 */
>> -	if (*status & STATUS_ERRORS || !(*status & BIT(OPERATION_DONE_SHIFT)))
>> -		ret = -ENXIO;
>> +	if (*status & STATUS_ERRORS || !(*status & BIT(OPERATION_DONE_SHIFT))) {
>> +		if (*status & BIT(MAC_FAILED_SHIFT))
> 
> Afaict MAC_FAILED indicates a different category of errors from the
> others. So I would prefer that the conditionals are flattened.
> 
> Is OPERATION_DONE set when MAC_FAILED?
Yes it is. I will change the check to the pattern you have suggested. It 
is less confusing..

> 
> If so:
> 
> if (errors || !done)
> 	return -ENXIO;
> else if (*status & BIT(MAC_FAILED))
> 	return -EBADMSG;
> 
> Would be cleaner in my opinion.
> 
> Regards,
> Bjorn
> 
>> +			ret = -EBADMSG;
>> +		else
>> +			ret = -ENXIO;
>> +	}
>>   
>>   	return ret;
>>   }
>> -- 
>> 2.25.1
>>

-- 
Warm Regards
Thara