Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210425175734.1310191-1-masahiroy@kernel.org>
 <20210425175734.1310191-3-masahiroy@kernel.org> <20210426085836.GA5802@willie-the-truck>
In-Reply-To: <20210426085836.GA5802@willie-the-truck>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 26 Apr 2021 11:01:43 +0200
Message-ID: <CAMj1kXFe7wf_3jmoSAM98s+sZS4Ex4yyoXXiToR-EX8K0e-aNw@mail.gmail.com>
Subject: Re: [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time
 instead of shipping them
To:     Will Deacon <will@kernel.org>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 26 Apr 2021 at 10:58, Will Deacon <will@kernel.org> wrote:
>
> [+Ard]
>
> On Mon, Apr 26, 2021 at 02:57:33AM +0900, Masahiro Yamada wrote:
> > Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  arch/arm64/crypto/Makefile                |    9 +-
> >  arch/arm64/crypto/poly1305-core.S_shipped |  835 ---------
> >  arch/arm64/crypto/sha256-core.S_shipped   | 2069 ---------------------
> >  arch/arm64/crypto/sha512-core.S_shipped   | 1093 -----------
> >  4 files changed, 3 insertions(+), 4003 deletions(-)
> >  delete mode 100644 arch/arm64/crypto/poly1305-core.S_shipped
> >  delete mode 100644 arch/arm64/crypto/sha256-core.S_shipped
> >  delete mode 100644 arch/arm64/crypto/sha512-core.S_shipped
>
> What's the advantage of removing the _shipped files? We included them
> originally so that we didn't require perl for the kernel build -- is that no
> longer an issue?
>
> I guess I'm just missing the justification for the change.

Removing 4000 lines of code is an improvement in itself, I suppose,
but I have no preference either way,