Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3487667pxy; Tue, 4 May 2021 03:31:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1gmlaP1sX1UInWQmyCDScQff8cc6gGRd21CMgpuBO0HSRJ4c3H5DlkVQ2gYXn2O+GZkxL X-Received: by 2002:a17:906:499a:: with SMTP id p26mr20431765eju.380.1620124310603; Tue, 04 May 2021 03:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620124310; cv=none; d=google.com; s=arc-20160816; b=dPWxQl9ARHXQ900vMdVHZwEoMs+BRjZ0RimalzGi0WUJM4EtLl6InjMZNJFwBmrmHZ 9oh3+l2ZZBJBYENK6ZvXIOPTWAZm8o8xPwwBw05FRjtmze5Q8MxM0bKqct1JFKAfqR+S VX5YykR4YxcUdI0Onb2o2h9Vc+P4zdoQlXm9OSBJeSQcH7sPIuNaGrIKdSFfEqAnNrCJ j9W1NgX2+mJ4SeO/Qs41aWKHlt6ibX7xI1DClPqVm6q3VAMKBP9KbchUEfIV/TKk19vX i7k3f1R8o/cDvLNzxNsPDVPyurWnwWmbI6/SPfjMNvzoicH2MwtGKLZDBMK/dJFd8z6A qApw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=DBsc4f+l4voGJHYOlPF6Xc92zcB7bng8WCzLiQLIcvQ=; b=VDJRV1LkwojLunb60eUF5RcloRCt9sxUlT1sCJG0d5LucUdcDJjfx2pbonNI5oKumb sxhX1+i/Ejm81R4HsZTsttP1xvM8hrnuiMfk9M4/vzHNmz0CHVHZRrYLM9R9Ktz/nj3v 89iS4R7o4rS/y0lm+Io8+YcFW+SzUf4GCHtq9V/H2eiEAhIiL04vji5Qp2ntXX7hXope S2mnEZk00XTQ0rOB7o2RtKPE/TqU9Lvz1W+kM2X5GYG245CgfnDUyaqugV0Cw2elebMK q1F4C2FQs4+GVA6/OwfmjMn3/v/Tz0ZLMEsXX33sUQYKr4TJDLdIgXBZnQMkXkP2iStX meWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f26si1192545ejf.128.2021.05.04.03.31.19; Tue, 04 May 2021 03:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbhEDKcA (ORCPT + 99 others); Tue, 4 May 2021 06:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhEDKb7 (ORCPT ); Tue, 4 May 2021 06:31:59 -0400 Received: from smtp-8fab.mail.infomaniak.ch (smtp-8fab.mail.infomaniak.ch [IPv6:2001:1600:3:17::8fab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A209BC061574; Tue, 4 May 2021 03:31:03 -0700 (PDT) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4FZGMn6ZThzMqPTp; Tue, 4 May 2021 12:31:01 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4FZGMl3dv5zlh8TS; Tue, 4 May 2021 12:30:59 +0200 (CEST) Subject: Re: [PATCH v7 0/5] Enable root to update the blacklist keyring To: David Howells , Jarkko Sakkinen Cc: "David S . Miller" , Eric Snowberg , Herbert Xu , James Morris , Mimi Zohar , "Serge E . Hallyn" , Tyler Hicks , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, David Woodhouse References: <20210312171232.2681989-1-mic@digikod.net> <52f54ebb-6ac7-4d68-f97a-74219ed88d0b@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: Date: Tue, 4 May 2021 12:31:43 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: <52f54ebb-6ac7-4d68-f97a-74219ed88d0b@digikod.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Are you waiting for the end of the merge window to push to linux-next? On 07/04/2021 19:21, Mickaël Salaün wrote: > Hi David and Jarkko, > > What is the status of this patchset? Could someone take it to -next? > > Regards, > Mickaël > > > On 12/03/2021 18:12, Mickaël Salaün wrote: >> This new patch series is a rebase on David Howells's and Eric Snowberg's >> keys-cve-2020-26541-v3. >> >> I successfully tested this patch series with the 186 entries from >> https://uefi.org/sites/default/files/resources/dbxupdate_x64.bin (184 >> binary hashes and 2 certificates). >> >> The goal of these patches is to add a new configuration option to enable the >> root user to load signed keys in the blacklist keyring. This keyring is useful >> to "untrust" certificates or files. Enabling to safely update this keyring >> without recompiling the kernel makes it more usable. >> >> This can be applied on top of David Howells's keys-cve-2020-26541-branch: >> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-cve-2020-26541-branch >> >> Previous patch series: >> https://lore.kernel.org/lkml/20210210120410.471693-1-mic@digikod.net/ >> >> Regards, >> >> Mickaël Salaün (5): >> tools/certs: Add print-cert-tbs-hash.sh >> certs: Check that builtin blacklist hashes are valid >> certs: Make blacklist_vet_description() more strict >> certs: Factor out the blacklist hash creation >> certs: Allow root user to append signed hashes to the blacklist >> keyring >> >> MAINTAINERS | 2 + >> certs/.gitignore | 1 + >> certs/Kconfig | 17 +- >> certs/Makefile | 17 +- >> certs/blacklist.c | 218 ++++++++++++++---- >> crypto/asymmetric_keys/x509_public_key.c | 3 +- >> include/keys/system_keyring.h | 14 +- >> scripts/check-blacklist-hashes.awk | 37 +++ >> .../platform_certs/keyring_handler.c | 26 +-- >> tools/certs/print-cert-tbs-hash.sh | 91 ++++++++ >> 10 files changed, 346 insertions(+), 80 deletions(-) >> create mode 100755 scripts/check-blacklist-hashes.awk >> create mode 100755 tools/certs/print-cert-tbs-hash.sh >> >> >> base-commit: ebd9c2ae369a45bdd9f8615484db09be58fc242b >>