Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [Patch v4 0/7] Add support for AEAD algorithms in Qualcomm Crypto
 Engine driver
From:   Thara Gopinath <thara.gopinath@linaro.org>
To:     herbert@gondor.apana.org.au, davem@davemloft.net,
        bjorn.andersson@linaro.org
Cc:     ebiggers@google.com, ardb@kernel.org, sivaprak@codeaurora.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
References: <20210429150707.3168383-1-thara.gopinath@linaro.org>
Message-ID: <48d51bb5-a107-4756-4767-f62131d28505@linaro.org>
Date:   Wed, 5 May 2021 18:54:18 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210429150707.3168383-1-thara.gopinath@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/29/21 11:07 AM, Thara Gopinath wrote:
> Enable support for AEAD algorithms in Qualcomm CE driver.  The first three
> patches in this series are cleanups and add a few missing pieces required
> to add support for AEAD algorithms.  Patch 4 introduces supported AEAD
> transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w
> infrastructure needed to enable and run the AEAD transformations on
> Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of
> unsupported special inputs.
> 
> This patch series has been tested with in kernel crypto testing module
> tcrypt.ko with fuzz tests enabled as well.

Hi Herbert,

I have fixed all the review comments on this series and fuzz tests pass 
as well. Do you think this can be merged ?

-- 
Warm Regards
Thara
> 
> Thara Gopinath (7):
>    crypto: qce: common: Add MAC failed error checking
>    crypto: qce: common: Make result dump optional
>    crypto: qce: Add mode for rfc4309
>    crypto: qce: Add support for AEAD algorithms
>    crypto: qce: common: Clean up qce_auth_cfg
>    crypto: qce: common: Add support for AEAD algorithms
>    crypto: qce: aead: Schedule fallback algorithm
> 
>   drivers/crypto/Kconfig      |  15 +
>   drivers/crypto/qce/Makefile |   1 +
>   drivers/crypto/qce/aead.c   | 841 ++++++++++++++++++++++++++++++++++++
>   drivers/crypto/qce/aead.h   |  56 +++
>   drivers/crypto/qce/common.c | 196 ++++++++-
>   drivers/crypto/qce/common.h |   9 +-
>   drivers/crypto/qce/core.c   |   4 +
>   7 files changed, 1102 insertions(+), 20 deletions(-)
>   create mode 100644 drivers/crypto/qce/aead.c
>   create mode 100644 drivers/crypto/qce/aead.h
>