Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp198729pxy; Fri, 7 May 2021 00:53:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQA0MclLYvuRll3BLdAb6Y0n5l6ttiGHj4fcZqF46Gu6MyTHrxzppySvZM7eEuweDzz1Cn X-Received: by 2002:a63:5004:: with SMTP id e4mr8453535pgb.61.1620373998414; Fri, 07 May 2021 00:53:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620373998; cv=none; d=google.com; s=arc-20160816; b=IBaideMdbDDPAAgxBeBvg4ArcNN/vDIUibjXRHoafNuD1qGkbNiO6WpRtcI1ocG7jx 7y8wbDCPINUAeQjb5J3SqF5JD8bEZe3+/mpC1oz29e8FN1FirC4xIAmgV7TATdfnZFCG Vxi/e4sEGegWxgASz5KhNkaOJl+guvTDjdmBTWaMVoqsDJGIe+0z2w2hEjrFYd/FWaA3 aQNuHIHPC/U8zrCRmwUuUU1jy/9b/h4kXM1MKn+CH7jrQqxY+0v7QzRIhuesE6SdBg2P IH8UxlH4pje0lnDZUu9KeuPcsmbajzED+wjjCUbEgOy5YprWiycNPrASA+RPQjMq12VE vuOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F5Ca315GO5rtUIX7gQhBTxsUnvwAyP4kw9ovIWoRcn8=; b=o9oJGqXus0B+V4wqmThuh3YGaHWj8JDtDkaMBSFmUbUe+xG0uHrL8Jj63B93e5/pXQ sDkFJQhYqusDRFfJNXjTsukJ57TX/8GRG1ALuiF1J9UtFKldZs66BP/U94eb/+3BJgkG sbGrvCLL/NoDnuazACX6bgbQhmRXLmzNDZJmENXCJ72b7991WSHc7M5LniWBDOnwyXMf sM7AUTwU2P1R3pL8jp7qvsZ4qZVQh/5dywd9mylx+Izon3tNu2qEFV2E3MqFBet34/Yw 44NreBW8ae9oMTG+SOdBFmzMMSh7BHsSN3o9yewGaT9SwxiP3ByitBvbd8RHEVUMAwtM TM9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jP+MW8zi; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si5958276pgv.436.2021.05.07.00.52.55; Fri, 07 May 2021 00:53:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jP+MW8zi; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234525AbhEGG5B (ORCPT + 99 others); Fri, 7 May 2021 02:57:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:56260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232974AbhEGG5B (ORCPT ); Fri, 7 May 2021 02:57:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6EBDD61164; Fri, 7 May 2021 06:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620370561; bh=5oJ7/xRlvEPW7909i7SHjDtYMORz8Ni4G8mzMy6rqdw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jP+MW8zigZV/sd1L87PnhXbALvTo9d67vwc/XP60wvtfTdukLArbMJqtPQ9NMMfuw gQhEaX1/iLx/h/SGYhVjwHvngJRUuLZNDyXZO41YN8TVqvoCrf9kTAcunhMmq+s6FQ Q/COIVr7z/bWhzdSORg2RGz0Vg7bcGM8uFFvVuqOKqu/DbXjepdZLBTuHNR+rvymJb qnqS1OX4TDCzJa1Ekf0SQB3AUUob3wAZ8jHhPexCXwHuoHg6cL6OOVXR5omjs1Ifcz ZOq4SGExO1EQDL287phRdKfOVJc1exgmynd0CAlR+ms8+N3875lAR5FMER5rj9htRd 5kst/LuIwZoXA== Date: Thu, 6 May 2021 23:55:59 -0700 From: Eric Biggers To: Kestrel seventyfour Cc: linux-crypto@vger.kernel.org Subject: Re: xts.c and block size inkonsistency? cannot pass generic driver comparision tests Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, May 07, 2021 at 07:57:01AM +0200, Kestrel seventyfour wrote: > Hi, > > I have also added xts aes on combining the old hardware cbc algorithm > with an additional xor and the gfmul tweak handling. However, I > struggle to pass the comparision tests to the generic xts > implementation. XTS can't be built on top of CBC, unless you only do 1 block at a time. It can be built on top of ECB, which is what the template already does. Before getting too far into your questions, are you sure that what you're trying to do actually makes sense? - Eric