Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1424238pxj; Sat, 8 May 2021 17:34:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCnDPN9eanQMX6CNUuwEA007f9gqgfd9ohn8IxRwyTAG3UsgKD6FKO8BuUjwMuBYfFHAU3 X-Received: by 2002:a05:6e02:6ca:: with SMTP id p10mr12069859ils.131.1620520488034; Sat, 08 May 2021 17:34:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620520488; cv=none; d=google.com; s=arc-20160816; b=IJ+C6K3SpsC0qThldOlRqbGA/JFvN16fLIAKC/bNplPNN1tSLT6dw7aLo43Mp6SLlN cMnjPLCZcbxi+aLpk8xj2plIvAhB+W8n3tb2HxTkruP0XKuyo5KJyfJ5EAqF1M29fZHI b5Q5lzE60xFDLHOiTEiA9/1l391tgV28e8FfBjaQceIb3gCVrykwiT9YB5fb098DW6jj 6k60Vs6pptrjKbvpyF3SlXDP5zDHolgfuQRVB7JJNAa6UmA4/xKY2daQlo9dlPAUUnQI 9z8qK4ufnVU8sVVCu/CkZnjAqyzcoeNfJ62JcLYt3xRo7CTBJuVHwk9hPyUbIJTnryK1 lu3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=nioUacGgmn1npsnF7UjH/G9jEKx4GaZezabtRTdAHNQ=; b=OSrYg1pmpaTwHp65lPsHyuseR+DhRbthxmvCuaqTmsVjL88/h6ZwvmGcWI3Uz1GZWC O2pWUXDTs3t2NQFuR2pDOFqPa4Zuq2GlIOBMlqLeMjChMzOC5H8d12LCTlQLdBAIVs1R BKzhi7xNaCAbQDEsvZ33wCcyMlsduYUTom6DF/pcr/Z/enxO4WGfTJf5m3n3s9n0Bvem ErpELIlP1H+8HFwJow6jPgZ5XyyxEPZUxHRvnXod9aiWvygJFd8yweJwtr5ZzpusggaU vdbu0kOg6jjY2AhYy44nFaWEVx0F1Fm9/+q+podBw+D9u58AucGWHFtU8mP0W9CRR3iP ZZ6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yYcpD96k; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o8si10797255ilu.133.2021.05.08.17.34.34; Sat, 08 May 2021 17:34:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yYcpD96k; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229620AbhEIAfd (ORCPT + 99 others); Sat, 8 May 2021 20:35:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbhEIAfc (ORCPT ); Sat, 8 May 2021 20:35:32 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73304C061573 for ; Sat, 8 May 2021 17:34:30 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id t11so18081948lfl.11 for ; Sat, 08 May 2021 17:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nioUacGgmn1npsnF7UjH/G9jEKx4GaZezabtRTdAHNQ=; b=yYcpD96kUzepSQpuQfBGevivuidrKiXsh8ogT+mWIOv1Qcmls5U6isOVtJAS74kOFF 2/RRdzcW8gis5NsZy5QJZrw2RPGepBediQrFxIDn+Ois12Ne/Q6wwt3WLnl4bq+r8eEo Say48A9hZMOjaWV5Iy/A73cfhSeGkz3nGoo1avWJcqw2OavtfZNdYpBcicZUITIVp2UF 0/QWkWxBl1M3l67KnFoYSDpYeDSHjRwP+h2eZt/9RClBnpfJClfLU1+OLWk9iMsMSs+Q vST+tnS90331h/ZuPy+6edYsE9FYCvN1WBbkjGtxEs2zXpyiNISxkZtivUrXni+jS4it LlpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nioUacGgmn1npsnF7UjH/G9jEKx4GaZezabtRTdAHNQ=; b=ZPNhdVj/Zhu/gnt4YpRa7mesrGbpDNIqvrElF7Vn+d7t/OUOUkMGfqFrvomZHB6JYE 6z/zFAlQicTdpoHb4mMsjQjKNHXSkzvCYUoYOHmqNS+ztNgHte1ZNc/z26YTvMopyI+G pIqN3AN3xd+oDzkuXP/3W3bdluCVDprLHV4pK7MIF+Ni10RUUq/P/zpyLkQqrmKqHP6N c8w1C804exqjgQEQQPpcK+QavbyVO4z7VTcv99ArkILJU3IQbf3FhiQ8AavnLetUVzZY SSbX1N0xGATcVgJDwdsqsNOzf5DU9o09Tw5529xdZb0OyMeEb1y56fP+0U564oxoTFzC OBwg== X-Gm-Message-State: AOAM532F2AHsG0m/9ZT0ukZD7zjl0OpGLWN5RkvveviVtI+YILMZwIbF r7RsW4CKRux1q76y7BjXsiSxAJQf/zWgk8ZxDSTMJA== X-Received: by 2002:a19:b0b:: with SMTP id 11mr11191818lfl.291.1620520469033; Sat, 08 May 2021 17:34:29 -0700 (PDT) MIME-Version: 1.0 References: <20210508070049.2674-1-thunder.leizhen@huawei.com> In-Reply-To: <20210508070049.2674-1-thunder.leizhen@huawei.com> From: Linus Walleij Date: Sun, 9 May 2021 02:34:18 +0200 Message-ID: Subject: Re: [PATCH 1/1] crypto: ux500 - Fix error return code in hash_hw_final() To: Zhen Lei Cc: Herbert Xu , "David S . Miller" , Andreas Westin , linux-crypto , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, May 8, 2021 at 9:01 AM Zhen Lei wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 8a63b1994c50 ("crypto: ux500 - Add driver for HASH hardware") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Reviewed-by: Linus Walleij Yours, Linus Walleij