Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2324978pxj; Sun, 9 May 2021 23:29:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKBdHGZcKXKPgBTDWcwDPyJReRu7IAhpaFMdtq13F2j+Ah9SjlCh8ARdD+t41kHm5DcZzz X-Received: by 2002:aa7:dad1:: with SMTP id x17mr27526637eds.47.1620628170620; Sun, 09 May 2021 23:29:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620628170; cv=none; d=google.com; s=arc-20160816; b=zAhfroH4gV1qjCXt4bwPs2L3MEtfvorXGTFpU06vAkY57CA5dDB2PQ2+wIKzLq7B2r GozXC/jlm4jgFCou/7mUeviOI95AZu2Tr0PO4pN9XXt55bNJ+H9q8974DyGt0EFlQhG/ Lf2zFtK0ZRYa5lpIW4MQDNeUmALv7Gpx4XWf51CcaFw5xnw3EIORmO+vZebjQqQ1nQ9y 7ivjhMTduu6rN8RLqTTROu/gYt0EHTfWBKR/3PjaxTAapM1oVvcMMGBDKOfwX10NqSMh PrSnG0VN3Mcn6V1sVSBY4bFtktSk8h1brNOUyLHW7MvJg1PjgeeozP5nJ9YtEXXINIXd e33A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id :mime-version:in-reply-to:references:cc:to:subject:from:date :dkim-signature; bh=8aR7WY5CZTqAiWESNPXFHkeKW1KzCf5tU1hXn+HW1Kw=; b=b3lc7D7r/DTypJo/79eAua6iri8YToYvpiSeax1SO0edg0hHG+C0gTySZxurZrznw3 d0ZEnlOSRh3OKoWK8tm/c1IVQtGweqmkoybgymQMwCbELUTpW8EB77IQ4iofa1PM+vPr 1JVXkt/bXPQRLHR2V29TZJDJMC2BZxDZLCs4DtT/scuOPqz3woECJUAlE+wlb25nvj/I bktbskEPhFhifHowIBvHu8Uw6ZAzWs+fV8QbdQxyMHxP7AZDLzEupJGcelwdJ+fmAnZr eiSUhDvnW5cLDU6W8w3HSJGDR5mNCYONq4ba2XYWt4oGc/rZJe71orbF6OP0QjKzt1FO OwOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s9HXI1C3; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p13si12201657edq.588.2021.05.09.23.29.06; Sun, 09 May 2021 23:29:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s9HXI1C3; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbhEJG3Z (ORCPT + 99 others); Mon, 10 May 2021 02:29:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbhEJG3Y (ORCPT ); Mon, 10 May 2021 02:29:24 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C1C0C061573 for ; Sun, 9 May 2021 23:28:20 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id h20so8626513plr.4 for ; Sun, 09 May 2021 23:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=8aR7WY5CZTqAiWESNPXFHkeKW1KzCf5tU1hXn+HW1Kw=; b=s9HXI1C3iGShy3MBh/f3z23PGT7oo5fSNATzZC5wVH3AyhfCxO3IHtSzJqwfJzLkr8 Sa94IYs01uF3tVT5jCOiTBQEMn/XoCyaQHBKgUAzdE3dBndEIbFJwrVf/l99vo8602z9 Tkhrh01vYkzv7Mdv2lLXElxNxjJLQfYBN7RetbJMrWZsFCTCsmKEj/YySnC5QIJoVXH/ dJlR8y/FZhpvfW2Gal5NjKzmAdxFgMeJluGzGy8uLVEuNTmMvvmPckmmPCHDD18dHnKj 4R/wJtCq/sQ6zh7aRVXYZyrEEkHXhZirPAOS3BtK0EfRGtwNsN9wEzj2w/OT30aaNivM YoxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=8aR7WY5CZTqAiWESNPXFHkeKW1KzCf5tU1hXn+HW1Kw=; b=nX7OKDuIltjNysgtPhUAkPhktAA8hbYBwr4fRAqMvmSBxBSIznh0IHjGHqwSZ5DcMm aFkghDR1aonWO8ew0NIE4mNWyZhWWHOy38wxf8/KLdBLBcABIwY0j8ocVdV48h5wAB3t aQlU8X9JklpPUg3neOIfb0+VaDv+iI7m/jrHP+vPxQ378GdR8T9UAKNV8Xx4yo/m+E8X 6Mvcp9kz0Imp4xnUoLXKRgiYRBEu/fMC1rUxZUmMR3CXlzBdR47vOhf7N/FtYa9qWzDm 6rhFVxuAfxd9XVIt1AIz5mWQpjx/GRPKY9iVQQfYCyP40COKFiDzVWCF/VwCYtk2/iDu EHwA== X-Gm-Message-State: AOAM5322IyQdYsr+FKkVVS2lNixThqPYgghprbgzS3zPaHeHVRj8aFmq orG8TGqzJ6GqpC4pc/fwwHY= X-Received: by 2002:a17:90a:20b:: with SMTP id c11mr25164418pjc.44.1620628099647; Sun, 09 May 2021 23:28:19 -0700 (PDT) Received: from localhost (60-241-47-46.tpgi.com.au. [60.241.47.46]) by smtp.gmail.com with ESMTPSA id d129sm3575475pfa.6.2021.05.09.23.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 23:28:19 -0700 (PDT) Date: Mon, 10 May 2021 16:28:14 +1000 From: Nicholas Piggin Subject: Re: [V3 PATCH 10/16] powerpc/pseries/vas: Integrate API with open/close windows To: Haren Myneni , herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: haren@us.ibm.com, hbabu@us.ibm.com References: <4b66c4eea2c0213be658180c987d81f3bb82293d.camel@linux.ibm.com> In-Reply-To: <4b66c4eea2c0213be658180c987d81f3bb82293d.camel@linux.ibm.com> MIME-Version: 1.0 Message-Id: <1620628043.agzu72dwu1.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Excerpts from Haren Myneni's message of April 18, 2021 7:08 am: > +static int deallocate_free_window(struct vas_window *win) > +{ > + int rc =3D 0; > + > + rc =3D plpar_vas_deallocate_window(win->winid); > + if (!rc) > + kfree(win->lpar.name); Oh, did this kfree sneak in here? The allocation appears in patch 11 I think. Thanks, Nick