Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2402200pxj; Mon, 10 May 2021 01:57:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOqsq4Ypnq/vBIOgZDkgS7f0jGKIxuqPDghRkWQXDGq7yFRM+ZKYGuhYYJMZEpYDt2/RNY X-Received: by 2002:a92:c569:: with SMTP id b9mr6889830ilj.117.1620637075375; Mon, 10 May 2021 01:57:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620637075; cv=none; d=google.com; s=arc-20160816; b=y3eIClPU3EDV//q6YWCb4DqR3PX6DNaFORdOv3MmEaffZ11JU4ds4VbzfoENwb90bA jWQrZ218nZChEtkDpxLpg+InCnHScI6MLJTRMzIN5SrW5NfufF/okNSKQk2F774JZMO4 gWUmBBv/w3u775AIckFENOSMzyRsFLdW59jcLwZ+eOAG2aGcVH17qmQIPYqCte0LA/38 rIOMSnSStjbPCDFNjbtN/XVbyYgX0xOdGucuztPKK1CgbiKSi48twkWKBgiG9BkHzqf+ JZ2pBxyNwWTzpfI5WN1+fptgNOHU7KBxV4bkntt0u9tbrNBNryaElaOdrInBYHQEoTYQ e+9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=2AjR5nCQfviBeg8Jo9VWdT6ux9xIAiw/70GtxrZFxyc=; b=ZcJOZJwgPeaJcSDzTluR4jq935bOm/HDA55AIXhXEOm0lsotFQBh3JSByF7mGJS7J8 aWiThsR9q3fQrLYng7LuZeyEMbsb3uvEBYt6wCxae7LgY+9QPMsgmmyO0E6VUOSTlskT qkR5JaMUHPUa7UW4EJTQ0vqr1pQIJrRH+FNfkC+7gXZG0j5ZHfIaoqytQXWAbaeZ2ZiY 6bA9hpYB0JodtKk/cWYw0/HDLDbbczw2QnegjBGgjwx3MwGej0y5rum3LBYFLFe22W5D vVT6NryWOxOb8+RjQtFPaoBh0TyL4eNxFxY3bQ8K4LTZTwbx/EKj7TmHvD+eNi39CjlM 2ZKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si14382645jam.78.2021.05.10.01.57.33; Mon, 10 May 2021 01:57:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbhEJI6T (ORCPT + 99 others); Mon, 10 May 2021 04:58:19 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2737 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbhEJI6Q (ORCPT ); Mon, 10 May 2021 04:58:16 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fdvwt125fzqV0R; Mon, 10 May 2021 16:53:50 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 16:57:04 +0800 From: Hui Tang To: , CC: , , , Subject: [PATCH] crypto: testmgr - fix initialization of 'secret_size' Date: Mon, 10 May 2021 16:54:08 +0800 Message-ID: <1620636848-38909-1-git-send-email-tanghui20@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Actual data length of the 'secret' is not equal to the 'secret_size'. Since the 'curve_id' has removed in the 'secret', the 'secret_size' should subtract the length of the 'curve_id'. Fixes: 6763f5ea2d9a(crypto: ecdh - move curve_id of ECDH from ...) Signed-off-by: Hui Tang --- crypto/testmgr.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crypto/testmgr.h b/crypto/testmgr.h index 34e4a3d..aead75d 100644 --- a/crypto/testmgr.h +++ b/crypto/testmgr.h @@ -2719,7 +2719,7 @@ static const struct kpp_testvec ecdh_p192_tv_template[] = { "\xf4\x57\xcc\x4f\x1f\x4e\x31\xcc" "\xe3\x40\x60\xc8\x06\x93\xc6\x2e" "\x99\x80\x81\x28\xaf\xc5\x51\x74", - .secret_size = 32, + .secret_size = 30, .b_public_size = 48, .expected_a_public_size = 48, .expected_ss_size = 24 @@ -2766,7 +2766,7 @@ static const struct kpp_testvec ecdh_p256_tv_template[] = { "\x9f\x4a\x38\xcc\xc0\x2c\x49\x2f" "\xb1\x32\xbb\xaf\x22\x61\xda\xcb" "\x6f\xdb\xa9\xaa\xfc\x77\x81\xf3", - .secret_size = 40, + .secret_size = 38, .b_public_size = 64, .expected_a_public_size = 64, .expected_ss_size = 32 @@ -2804,8 +2804,8 @@ static const struct kpp_testvec ecdh_p256_tv_template[] = { "\x37\x08\xcc\x40\x5e\x7a\xfd\x6a" "\x6a\x02\x6e\x41\x87\x68\x38\x77" "\xfa\xa9\x44\x43\x2d\xef\x09\xdf", - .secret_size = 8, - .b_secret_size = 40, + .secret_size = 6, + .b_secret_size = 38, .b_public_size = 64, .expected_a_public_size = 64, .expected_ss_size = 32, -- 2.8.1