Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 May 2021 19:51:46 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Eric Biggers <ebiggers@kernel.org>,
        Will Deacon <will@kernel.org>,
        Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH v4 2/7] crypto: aead - disallow en/decrypt for non-task
 or non-softirq context
Message-ID: <20210519115146.bmrlfrchmz5tt2e2@gondor.apana.org.au>
References: <20210519112239.33664-1-ardb@kernel.org>
 <20210519112239.33664-3-ardb@kernel.org>
 <20210519112930.sgy3trqczyfok7mn@gondor.apana.org.au>
 <CAMj1kXGsxFzx8XTwhBRma_eSmnAHDZHox9X+SYDn0JYfPBVbYg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMj1kXGsxFzx8XTwhBRma_eSmnAHDZHox9X+SYDn0JYfPBVbYg@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Wed, May 19, 2021 at 01:36:37PM +0200, Ard Biesheuvel wrote:
> 
> So if we do need to check this, we should check it here. If we don't,
> then we can drop these patches.

Historically other things would break in nasty ways if you tried
to do crypto in hard IRQ contexts, e.g., overwritten kmap slots
back when we had individual slots for each context, but I don't
think we've ever found anyone crazy enough to do that to warrant
a run-time check.

I'd just leave it out for now.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt