Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp933711pxj; Fri, 21 May 2021 02:33:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzy3SaABvr31n21T/JVMTCbewEu0OHMxmmsN3oyzzVlXs9bySXqnqCDqOnycppBsXj1IWQv X-Received: by 2002:a50:fd13:: with SMTP id i19mr10208304eds.386.1621589628743; Fri, 21 May 2021 02:33:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621589628; cv=none; d=google.com; s=arc-20160816; b=ontnJ39NTAyFs7SPa8hxe0607uS8udR506H2/dPt+KhL4Z5ZEuwerh0VlgW4904GEF NJvMaJvmrfKDRCZRaPRTOUHe26isMIbz4WlxQwdpTDt2QMPuvJgl6WGc5pew2ATFT7Aj yQaJe4INiNRbkkzkSMqg1Au5GlNfyDsBzRNL1RdGWql6NOnYyQIHKOV+CSl6CtyYOn9s Re6unm0xQKUAz+i129/qqM2l6zlLNH+wnrL5usqdf4IEO1jjwaenjquYgz/4tLJ6jL6V eQMgwoIYzTQ+FA3umyz0l3lSG1LsPg0AKZ0SlzZVVoQILIY2qeyuXAY6/kepTPVMzi1o 2GkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:mime-version :dkim-signature; bh=5yJ93m6CegNlSMHAeMKjyxLyMafra/bBo5cvOo7vxug=; b=GUXNFv3rV/NiQaZ7hNeJBBaYzGXmHrY2II3+38cWtkptttJ3V7T1IYSJYBrJ2hbMoe Fh4OXHAU2QcAuyjqxOa1ittIrb8Vh6MPxmHdamim3f1cLubLzpALO+alF4okyi0KpQaX szSoAMgKPkjkt3f9D658PXULIGCRTpzjgdxcgvt/FIZLJ1MiHp/+RNWKoB1U5G/1favX iWKf58Jbz7tNTxBL/TF/YDKY1c0sA2OekXToe0gEnS7kHwXj+UQe6Ds/qsN8m2DhRrZp zRB+AgH5LDspeGfpXeyWN819h0sgrT+8RQoCKnrpF/1b3zPo0P++JszZRoIOl53WEOCX 7/7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OHl4KuE0; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si4866941edv.272.2021.05.21.02.33.24; Fri, 21 May 2021 02:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OHl4KuE0; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238891AbhEUDZs (ORCPT + 99 others); Thu, 20 May 2021 23:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238890AbhEUDZk (ORCPT ); Thu, 20 May 2021 23:25:40 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01F99C061574 for ; Thu, 20 May 2021 20:23:46 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id d16so13890321pfn.12 for ; Thu, 20 May 2021 20:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=5yJ93m6CegNlSMHAeMKjyxLyMafra/bBo5cvOo7vxug=; b=OHl4KuE0KdFyZ8dehKBcShzJE8s8GtJAKwXzgEzq/w4irCWtLKlO+abL6xE/fyIjsl mNXH9j/fo6MJQ103l1NxrAL0dFS/KbYNdVS6GvF6ntBfh4VSnIm8rjxw+Zl7BxYnCOPW JNkRi+WAnRagh0HaVyGzTVxGo+Lt6kVBhTAhDMjkuUzAXcp1Tfca/nbeJ3LQ6xs+OBSp 5WkXsnl10z+0rTl3xVoci9j9kAdgBOXp8pnu/rdKvAsWAWK2geyIDSa4VXjgZ1Z0mhqC RNxOpbiCZ0tY74lWxf0H6Ri++d11SPJJd3Jko2YBl8Ujvwh4H7bN8+K8ZHMLdVAfAG8c xfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=5yJ93m6CegNlSMHAeMKjyxLyMafra/bBo5cvOo7vxug=; b=jfckIV3KOMHvEqrEmkIgqVxVD+G6fypqnXOMzlefKdNWUoFkzcsH+bQWKZUWkQDzNy ya4X+Si5R06/locU5gcOm8IrfyVc1HycRXQ5P4/deE0LuphVOxfJNqqVM4rHlPXMvXL8 FlpKLcb0I7XJI7qUREUyXOFigJ1gswjtruzaFU83E/i3oxgoM0Upvoy/cQr7KrycCXzG +3kZYpOyWXHKUE5/K2VbdB3yjMigPPUBURK3CdfFBrHGLIKQrK0H6B+DgFmWEhgF8kgT 7WhW2yGtSGwBF2ISzoti/VlCloIlglZtng7mPrdJVk6NlS+xFiuhEoQvQS1KaWIbb+8/ YI4g== X-Gm-Message-State: AOAM532OQG8NPNLSZAXFaZ1VoF7JdlgagM4IoMXfDVLQrwiQwk+9Od3C /GK/G0gbUIfk+RDO0CwTo1GGJOYw+oiJdiVrD7vobjZwZMSB4Q== X-Received: by 2002:a65:6a4f:: with SMTP id o15mr7574107pgu.399.1621567425529; Thu, 20 May 2021 20:23:45 -0700 (PDT) MIME-Version: 1.0 From: Yiyuan guo Date: Fri, 21 May 2021 11:23:36 +0800 Message-ID: Subject: A possible divide by zero bug in drbg_ctr_df To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, davem@davemloft.net, Yiyuan guo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org In crypto/drbg.c, the function drbg_ctr_df has the following code: padlen = (inputlen + sizeof(L_N) + 1) % (drbg_blocklen(drbg)); However, the function drbg_blocklen may return zero: static inline __u8 drbg_blocklen(struct drbg_state *drbg) { if (drbg && drbg->core) return drbg->core->blocklen_bytes; return 0; } Is it possible to trigger a divide by zero problem here?