Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210519112239.33664-1-ardb@kernel.org> <20210519112239.33664-3-ardb@kernel.org>
 <20210519112930.sgy3trqczyfok7mn@gondor.apana.org.au> <CAMj1kXGsxFzx8XTwhBRma_eSmnAHDZHox9X+SYDn0JYfPBVbYg@mail.gmail.com>
 <20210519115146.bmrlfrchmz5tt2e2@gondor.apana.org.au>
In-Reply-To: <20210519115146.bmrlfrchmz5tt2e2@gondor.apana.org.au>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 21 May 2021 09:30:11 +0200
Message-ID: <CAMj1kXF9jGE+OuQfQqQrmd36j3ipduVOu7ciOg51PSZpfs6jxQ@mail.gmail.com>
Subject: Re: [PATCH v4 2/7] crypto: aead - disallow en/decrypt for non-task or
 non-softirq context
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Eric Biggers <ebiggers@kernel.org>,
        Will Deacon <will@kernel.org>,
        Android Kernel Team <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 19 May 2021 at 13:51, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Wed, May 19, 2021 at 01:36:37PM +0200, Ard Biesheuvel wrote:
> >
> > So if we do need to check this, we should check it here. If we don't,
> > then we can drop these patches.
>
> Historically other things would break in nasty ways if you tried
> to do crypto in hard IRQ contexts, e.g., overwritten kmap slots
> back when we had individual slots for each context, but I don't
> think we've ever found anyone crazy enough to do that to warrant
> a run-time check.
>
> I'd just leave it out for now.
>

Fair enough. Would you like me to resend the series with these patches
left out Or are you ok to just take the remaining ones (assuming there
are no issues reported with those)?