Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp969241pxj; Fri, 21 May 2021 03:28:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcxBv2kSIGl0Q4+Nf5ohR+rIvUSo2YX0gD44jSC95b5a5rRqw1+bUyiKzrFQ/MBLGljOWy X-Received: by 2002:a05:6e02:1d82:: with SMTP id h2mr9390935ila.78.1621592914894; Fri, 21 May 2021 03:28:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621592914; cv=none; d=google.com; s=arc-20160816; b=KsckYhzkyZH9b7kRlpGQ7tJ/aqWQtgsFk/9q44KINPFjfbtAQUIXEXF0WB8PLCxX2Z z0DGzT8LOjrC/6/QR1RTcDYYua6ZU64G4fuwr2dGqba0eEZtWZIMDfogbNY1SU6wQFyz bldadITrXkrhq4cOD30RhlJCoP8v5jG8YU6Ne5ifDl8hAuV1w792Q95982Mz7M3zaHlq +AwDFOaYWnNFF34d4tYZYz4YAPmASmSoFZdnm8hFToO4t6OJCRKjYIWKjocPj3LHS4j6 vW9Ib1aloROzq1ObalLcK2wOntehXvzIHVZVo5WvttEj7P27jqvS0X842cUbC7LgngzQ ztqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=a5Lx9ma8QRKaBZx2u+cTP07xwqMRxMOKvEq+Jo2XjMA=; b=UBk1tYvlyHyqkK6M19o7twmN/fpHCM6mrsiIPVsYvZj7X76+6BOG5Mgbcr0oc6zVu+ tlBr2yXs1O4KoM/tosMakvj0XF7r6GePNYLS4o65OaPpcBsw/4l9ew3wF1RinlRjBTwq 55+Tx5MQdG74Kuw5wdPVURFXVd6d06XtRZXcihD22AkGEHP/lIVEXGc2aXYFkxOXHfeS nN7IeYFSzqA1W8jmEDKKwMWMLqePjXZFcH9JlKhNIy75R7WoV6Pd+xHk5JFqeL5TDjGl 41+59uJrSq8mDa8qlVQThfcGNE3skbfOqVOo1jpGgzidQVratRq0x3QV/umOrKz9l16x eaUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b5si4992144jav.78.2021.05.21.03.28.16; Fri, 21 May 2021 03:28:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbhEUIYO (ORCPT + 99 others); Fri, 21 May 2021 04:24:14 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:56076 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbhEUIYN (ORCPT ); Fri, 21 May 2021 04:24:13 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1lk0Qf-00051X-Lp; Fri, 21 May 2021 16:22:45 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1lk0Qf-0007WU-I1; Fri, 21 May 2021 16:22:45 +0800 Date: Fri, 21 May 2021 16:22:45 +0800 From: Herbert Xu To: Hui Tang Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, xuzaibo@huawei.com, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] crypto: hisilicon/hpre - fix unmapping invalid dma address Message-ID: <20210521082245.af6x2lotbrfbkanu@gondor.apana.org.au> References: <1620637375-39155-1-git-send-email-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620637375-39155-1-git-send-email-tanghui20@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, May 10, 2021 at 05:02:55PM +0800, Hui Tang wrote: > Currently, an invalid dma address may be unmapped when calling > 'xx_data_clr_all' in error path, so check dma address of sqe in/out > if initialized before calling 'dma_free_coherent' or 'dma_unmap_single'. > > Fixes: a9214b0b6ed2(crypto: hisilicon - fix the check on dma address) > Signed-off-by: Hui Tang > --- > v1 -> v2: Fix sparse warning. > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt