Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp969735pxj; Fri, 21 May 2021 03:29:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw56BiuX8pMch4urL3Neoi9eh/if7lwzu1SaaWqu4+r7qi3hhF0chQMqwW45PnGoJZq/U93 X-Received: by 2002:a92:c951:: with SMTP id i17mr10423521ilq.198.1621592967765; Fri, 21 May 2021 03:29:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621592967; cv=none; d=google.com; s=arc-20160816; b=qGWdO6U5NFXy++7OGA3mqQqTYSMfrDGgM0H2omdRPLfe11cTVoJMmzvZEEE1u2sVA4 wYDc0seZHcpg49sObVFAh9/4WrRbgzEgAi6bLQAslabBcnAxvsplJ7camWtK7XvOadz+ jAMAYis/K4AWupWT7hr9Ex5Vfd1xcQAI9b7EtjtQu7TaUO8HQapgwzJcnrNtpkUMBxKO icWmgBxTiERw8YuVv1RWcvYGs4OX1x/HVnayGqvQ45FkG/jlEbU+kIDLad++VsmzcT3h tTBTxZgnhfiaQiJgmCGHHYmt5Gf90Q97jXrswKCxaAi0J4/l1L7JGPSjYgMbYs73tqdZ CiRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=j0V8CYJ+7VcN5bLacGz9UUSUSa3TkjLV890YQW13tsw=; b=yl2ZgtqVNGq34uSjWX7uAT3dsaT0/E53IeGWTqv68kLueTTSlwQTbneYteS15vCsbn z/SxNhURV0xDSrvsoKqOYjBBfcQTP2Hl5e94lxC27OjBvE0WtSZchSV74i0Cs/8d/S66 LpobMFeExYyaqEWaDKCOqQy4/HI1Y4eUdcAJBbUR2bhPQa2G1Ut3dQRJvRCMpfDjY9KL 3PTNNUqWI7qvrdwr/yeCJlXmgs4Y5nhUCwA4iH/v7/9IOCR7lBJSG1pOe3S8zQYkMrzs SmqNjt2MdCeCbtJcgNIbBo4+UJPxidfKqMum1NJNYYxZJ0j1XvAoZSu6P7EO5oUGiYck WHnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si5151635ioh.104.2021.05.21.03.29.03; Fri, 21 May 2021 03:29:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbhEUIX5 (ORCPT + 99 others); Fri, 21 May 2021 04:23:57 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:56058 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbhEUIX5 (ORCPT ); Fri, 21 May 2021 04:23:57 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1lk0QN-0004zX-2F; Fri, 21 May 2021 16:22:27 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1lk0QL-0007W2-11; Fri, 21 May 2021 16:22:25 +0800 Date: Fri, 21 May 2021 16:22:25 +0800 From: Herbert Xu To: Hui Tang Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, xuzaibo@huawei.com, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: testmgr - fix initialization of 'secret_size' Message-ID: <20210521082224.dzarrsqzxygschlw@gondor.apana.org.au> References: <1620636848-38909-1-git-send-email-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620636848-38909-1-git-send-email-tanghui20@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, May 10, 2021 at 04:54:08PM +0800, Hui Tang wrote: > Actual data length of the 'secret' is not equal to the 'secret_size'. > > Since the 'curve_id' has removed in the 'secret', the 'secret_size' > should subtract the length of the 'curve_id'. > > Fixes: 6763f5ea2d9a(crypto: ecdh - move curve_id of ECDH from ...) > > Signed-off-by: Hui Tang > --- > crypto/testmgr.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt