Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp969960pxj; Fri, 21 May 2021 03:29:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+67A+FzcoD8eR3ELWYCY3Z/GEVjHe9JkO0/406Z+vj3T7IUOo26sEMPRGnTJZEnnIwikA X-Received: by 2002:a5e:c742:: with SMTP id g2mr11172147iop.40.1621592989032; Fri, 21 May 2021 03:29:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621592989; cv=none; d=google.com; s=arc-20160816; b=Iit75OCc+lNXet7dhz9nrMQWRZEDXQKtpClVUt2ofUeiZkTjD+dW1AlEWxLlQx6XCf rADKHp95Arobp9dZbuVH/uV7H1jbER4MMYTTsYnMjc+55crtS++euwLe3DUvJ8+hn/Ve EdAmFERHxavp9ymGpL4y3ZGOrtZvwj+ExaUZ/tLO7uhRL8RRvCZC+BeWpnmjHMmUChdw Kdt0GTZSYAt5j9oJWrT76ew5MvriWpkXE14XiWduGDQ5drZWc3IngtC8+x9ZI5UDOW+z ubEl5jJVo5zqNEe/rBodHEGLksgHaXqTp2THAAe5hbpPtRY3Ovnt2DEh+1SRrPeJhfiG 8/jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=hIyk/WEFp2sfENc0xZigT8B/E6uzVun14jeSRhsvWpg=; b=tAkE/SzsNfZs9S1llvV4a7DDT7n4QUmpJMcxSSEgVPED/NeK2cD5Jw0N2eYUZZjeNK C2Wnuxc1bdOS0Ax8dzJs4ITA/YkYg+w3KPkFW36iMSt6/sSIZw22yxo/Ts4AoAt3adu4 NGN4nBEJNy/guGk8TDMoiEigWhqt3yejKXORhh178AntZU+5kV+yG3D0EBrXRVeraOB3 tCkSgmWKXG9EhpVF/0nNx4zWVhjtrHLso7CDQxQL0PR04qMNg9vC+IraF4cH7gZ1HhKc +G++1UQahDQI79dQImeYQyjFWwFs1lqUn6ABHhBaz2pnAyRYFXbaY+Y+JZIuVLk4/Iyt mTgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si5626746ilt.149.2021.05.21.03.29.23; Fri, 21 May 2021 03:29:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231342AbhEUIZC (ORCPT + 99 others); Fri, 21 May 2021 04:25:02 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:56124 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231307AbhEUIZC (ORCPT ); Fri, 21 May 2021 04:25:02 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1lk0RR-00055o-HX; Fri, 21 May 2021 16:23:33 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1lk0RM-0007Xf-Ps; Fri, 21 May 2021 16:23:28 +0800 Date: Fri, 21 May 2021 16:23:28 +0800 From: Herbert Xu To: Christophe JAILLET Cc: thomas.lendacky@amd.com, john.allen@amd.com, davem@davemloft.net, gary.hook@amd.com, brijesh.singh@amd.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] crypto: ccp - Fix a resource leak in an error handling path Message-ID: <20210521082328.ftdnzvztmqmnxu5r@gondor.apana.org.au> References: <4af832b7e75b729ebfb0f07fe039dc47712512c2.1621146079.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4af832b7e75b729ebfb0f07fe039dc47712512c2.1621146079.git.christophe.jaillet@wanadoo.fr> User-Agent: NeoMutt/20170113 (1.7.2) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, May 16, 2021 at 08:58:04AM +0200, Christophe JAILLET wrote: > If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be > called as already done in the error handling path. > > Fixes: f4d18d656f88 ("crypto: ccp - Abstract interrupt registeration") > Signed-off-by: Christophe JAILLET > --- > drivers/crypto/ccp/sp-pci.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt