Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <878011e1735e84d4e16ab68d9f03e2f62b531314.camel@chronox.de>
Subject: Re: [PATCH 1/3] crypto: ecdh - fix 'ecdh_init'
From:   Stephan Mueller <smueller@chronox.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Hui Tang <tanghui20@huawei.com>
Cc:     davem@davemloft.net, linux-crypto@vger.kernel.org,
        xuzaibo@huawei.com, wangzhou1@hisilicon.com,
        linux-kernel@vger.kernel.org
Date:   Fri, 21 May 2021 11:36:37 +0200
In-Reply-To: <20210521081356.3bnytzdxhjkgzb7g@gondor.apana.org.au>
References: <1620801602-49287-1-git-send-email-tanghui20@huawei.com>
         <1620801602-49287-2-git-send-email-tanghui20@huawei.com>
         <20210521074553.w6qtqv5nnbdbqycx@gondor.apana.org.au>
         <2a5bcd22-455d-6348-9a72-dc5a7ab49ca6@huawei.com>
         <20210521081356.3bnytzdxhjkgzb7g@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am Freitag, dem 21.05.2021 um 16:13 +0800 schrieb Herbert Xu:
> On Fri, May 21, 2021 at 04:08:10PM +0800, Hui Tang wrote:
> 
> 
> Stephan, can you confirm that both ecdh-nist-p192 and ecdsa-nist-p192
> should be disabled in FIPS mode?

Confirmed with the following caveat: sigver is allowed due to legacy
considerations. Siggen / ECDH is only allowed for curves P-224 and higher.

As we introduce ECDSA today, I would not consider a legacy mode and thus
disable P-192.

Ciao
Stephan