Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1018908pxj; Fri, 21 May 2021 04:43:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGLCs0q+q+B7ShNSW3+upbuMWszDMwi1rd/7K7vECYyulV4boqEoqY0Gg/pFLGF8ucsb1f X-Received: by 2002:a17:906:bc43:: with SMTP id s3mr10022143ejv.76.1621597400870; Fri, 21 May 2021 04:43:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621597400; cv=none; d=google.com; s=arc-20160816; b=S2w+iaSat7jNU57Xa7S2YxLOE24fu7f7kCE11pcsbTpYZUgZ7NqARpWdAv0vcNexFf T8HG5djfiN8E/nuau3lFbSd9TCw5NQtA8Nl6k43uV/xNO/YtBT42vHT7H4xQiXhouBee 4cowB68itjI97LlcbhxepHRdNneAmGqZIgVYYLUVYyMJ324wMtO9WSd0CaXPHyCj5VyD YlFbyuDoopyKVLYJl2WSg/h9jSS7AUWfoPJd3PrY271BPgVOB+dZcJLPiIrUXLdUEeGM cQQD2QRG8KdUZaWXtCDt6rlNdFNeknlMLZ13ECAoEnC6LyZkD+Mrd+jQeV7ThCvN35I+ e3cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=H5vuPQpn3WGRBslFrFjUXbyqnNNcK45d8J/Na7zr6Q4=; b=biq9neqRsccXyb1nFVU0T0eKPkHUQ/5zUnKb5gweiqPGv0W6JqwR8tIFo3EkQreDDH CyHI+GI38aq6aLSmVMTX98aBgZbyhFngnBxEFFVX10eFXAB6xH1c0KbszGQlLfq/2i7/ 6h3NspJPAW1aBo4CBWQt/4i62QuY5mfaA082PpqSRYOoaT2w2cVhuVrcAUts3bc0r8Jk N/qXbi/KMHic35/GXYzuzltGKXKhDNnShNzfDSx1Z3FoBcMTo9OYf3ddURMnFFbq31WZ IJjLgfCGnAnNEwajwXEWkVTSqrYvXTtw+8W6CAv5GdTjtNB7aTEA9CmiRCC7pK8sY2Kv /rVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp6si6610348ejc.89.2021.05.21.04.42.57; Fri, 21 May 2021 04:43:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232353AbhEUKHP (ORCPT + 99 others); Fri, 21 May 2021 06:07:15 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5654 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231995AbhEUKHN (ORCPT ); Fri, 21 May 2021 06:07:13 -0400 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fmhxd4Yf2z16QhZ; Fri, 21 May 2021 18:03:01 +0800 (CST) Received: from dggpeml500012.china.huawei.com (7.185.36.15) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 21 May 2021 18:05:48 +0800 Received: from huawei.com (10.67.165.24) by dggpeml500012.china.huawei.com (7.185.36.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 21 May 2021 18:05:48 +0800 From: Kai Ye To: CC: , , , Subject: [PATCH v2 2/2] crypto: hisilicon/qm - fix the process of VF's list adding Date: Fri, 21 May 2021 18:02:44 +0800 Message-ID: <1621591364-46526-3-git-send-email-yekai13@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1621591364-46526-1-git-send-email-yekai13@huawei.com> References: <1621591364-46526-1-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500012.china.huawei.com (7.185.36.15) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org If Kunpeng 920 enabled the sva mode, the "qm alg register" process will return directly. So the list of VF wasn't added to QM list. Signed-off-by: Kai Ye --- drivers/crypto/hisilicon/qm.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index deb104e..c671f94 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -4256,17 +4256,17 @@ int hisi_qm_alg_register(struct hisi_qm *qm, struct hisi_qm_list *qm_list) int flag = 0; int ret = 0; - if (qm->ver <= QM_HW_V2 && qm->use_sva) { - dev_info(dev, "HW V2 not both use uacce sva mode and hardware crypto algs.\n"); - return 0; - } - mutex_lock(&qm_list->lock); if (list_empty(&qm_list->list)) flag = 1; list_add_tail(&qm->list, &qm_list->list); mutex_unlock(&qm_list->lock); + if (qm->ver <= QM_HW_V2 && qm->use_sva) { + dev_info(dev, "HW V2 not both use uacce sva mode and hardware crypto algs.\n"); + return 0; + } + if (flag) { ret = qm_list->register_to_crypto(qm); if (ret) { @@ -4291,13 +4291,13 @@ EXPORT_SYMBOL_GPL(hisi_qm_alg_register); */ void hisi_qm_alg_unregister(struct hisi_qm *qm, struct hisi_qm_list *qm_list) { - if (qm->ver <= QM_HW_V2 && qm->use_sva) - return; - mutex_lock(&qm_list->lock); list_del(&qm->list); mutex_unlock(&qm_list->lock); + if (qm->ver <= QM_HW_V2 && qm->use_sva) + return; + if (list_empty(&qm_list->list)) qm_list->unregister_from_crypto(qm); } -- 2.8.1