Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     <krzysztof.kozlowski@canonical.com>,
        <linux-samsung-soc@vger.kernel.org>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] hwrng: exynos: Use pm_runtime_resume_and_get() to
 replace open coding
Date:   Mon, 24 May 2021 10:32:33 +0200
In-Reply-To: <1621569489-20554-1-git-send-email-tiantao6@hisilicon.com>
        (Tian Tao's message of "Fri, 21 May 2021 11:58:09 +0800")
Message-ID: <dleftjy2c4zg4e.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <1621569489-20554-1-git-send-email-tiantao6@hisilicon.com>
        <CGME20210524083244eucas1p263470ad84270aa59c06432c92cf56280@eucas1p2.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2021-05-21 pi=C4=85 11:58>, when Tian Tao wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>  drivers/char/hw_random/exynos-trng.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_rando=
m/exynos-trng.c
> index 8e1fe3f..d71ef3c 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct =
device *dev)
>  {
>  	int ret;
>=20=20
> -	ret =3D pm_runtime_get_sync(dev);
> -	if (ret < 0) {
> +	ret =3D pm_runtime_resume_and_get(dev);
> +	if (ret) {

pm_runtime_resume_and_get() (see include/linux/pm_runtime.h) checks for
ret < 0 and returns it, so I think it is better to keep (ret < 0).

>  		dev_err(dev, "Could not get runtime PM.\n");
> -		pm_runtime_put_noidle(dev);
>  		return ret;
>  	}

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmCrZKIACgkQsK4enJil
gBCyEAf/d2Zw70kujgGEQWPrkeLmvoZmGFM7fhsVYADO4PvD55QRF3Er0bLWC2sf
xd6gbcVU935trDA3UfRIT5fgEx6Dzxudz8CGmDbGnrX6cSV14kSOrYy8FEC7++Cw
19dPfIayqUszjUMprKoHlNcs+02y/Uth1OFm58uB0ptPwbvRmzpNAQiRcEFyc/u7
zv1py8TYLwMa1hptu1ZgZV1uqXA+8lktA8iOQHkWqp78H2wcm82sGalTCmvE1v4U
coe+NGbUVBCx7NqY802VzZh53MxEd+nYzxMk55DEF0YzCG2rsp3DwE9NFDv5EPCn
p0+0v4nwQn/K/4yUvD8ChDGcxtYQkA==
=J0qR
-----END PGP SIGNATURE-----
--=-=-=--