Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     <krzysztof.kozlowski@canonical.com>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to
 replace open coding
In-Reply-To: <1621857218-28590-1-git-send-email-tiantao6@hisilicon.com>
        (Tian Tao's message of "Mon, 24 May 2021 19:53:38 +0800")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Tue, 25 May 2021 16:43:28 +0200
Message-ID: <dleftjcztezxf3.fsf%l.stelmach@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <1621857218-28590-1-git-send-email-tiantao6@hisilicon.com>
        <CGME20210525144338eucas1p1ffe21ffce47146203dd1f6211a0e5408@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2021-05-24 pon 19:53>, when Tian Tao wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> v2: drop unnecessary change about if condition.
> ---
>  drivers/char/hw_random/exynos-trng.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>

Acked-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_rando=
m/exynos-trng.c
> index c8db62b..9cc3d54 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct =
device *dev)
>  {
>  	int ret;
>=20=20
> -	ret =3D pm_runtime_get_sync(dev);
> +	ret =3D pm_runtime_resume_and_get(dev);
>  	if (ret < 0) {
>  		dev_err(dev, "Could not get runtime PM.\n");
> -		pm_runtime_put_noidle(dev);
>  		return ret;
>  	}

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmCtDRAACgkQsK4enJil
gBCuvggAoayVKezXZk6q4SVacoUpczzrC9WgjDg8HVQ3kf4FgV8k4SKfm7T4nJQg
TElby85VrGFssGPk58IrZVK9OkfYg+ATUI+YYnS2HUKny1JeDuh4nIZXKNZvDJOD
A92k+fZl9hh9jSuFpF1cyKOsB9M2ZC2oGiwkrMIKVLC4IC8Mctj3CSYb58zTajmT
ScQb1vGl+swv1F2ty78DQ173Ul9+QV4fJMljxZ6JWvS0yDTNbx5ar6VhHeJyXZXJ
Qo7qWi8R/LJE4H3iciiZePivcTZa3UtSJmy5EzRbDb1cTBESi5jCvBqu74gmVsT0
8W7IhZrlO8zuU4uGUtKkdZfSXx1RmQ==
=hxUW
-----END PGP SIGNATURE-----
--=-=-=--