Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp169136pxj; Fri, 28 May 2021 00:43:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZyfEowCY2LAnWdKTrFQj1cwR4dROkXGNAHiO/NTMCxbQGCOxw4UWBE0VKXlD1xX4x+Fg0 X-Received: by 2002:a05:6402:3513:: with SMTP id b19mr8425482edd.137.1622187838974; Fri, 28 May 2021 00:43:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622187838; cv=none; d=google.com; s=arc-20160816; b=JuGTxmQ+x13YIsKS/yA2A2UYI46kv+9m9d+6y5w1eBuOHeTMc5V70WFQmNn4KRuk1x 3upU8aBa5K8WXTX+8v8tsBngwrSaIuGAXCgXyufyIo2eSZg/2BSgP0t2r4r80zFIa+Wj R3R/irmF/X5HxSR/OZlkLj7x4ojpd3plPafwoGwozQY36BgzJGR4ehPAaJ68aIbwAzKM s9UYNW1m7C69wlNSRmcXA4rbFu5p868ze5h31S/p6EHwcI/UKVSFKGWRsQB04LbvlaN5 EQ9+EpkwofUuqCzHwLqxHUTbQDs0kbZv84KKYiBokJmg56xl7aXcFRVE0jNTFMviUBS2 a5Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=vTa4ixP4aImQqB2sZ8/BZ8rGbX1PCpFSu5dev+yVwCM=; b=L6oYwhyzjVC0qOnyWWP2KzP/Pg9ASJDo9DSJiP5l9lWpLsXtwHBAi5EpH6bjvT+voA DTmmuCsy8IRPvUPt3AcytgEZ2+aE3AFHif6i/f/sRulbAkXfjguHm4XSSIIFXKex3nkp AXMiImpsBEBdsjQVuNcF2E772Mx9SEKAV80qrCkry1lcJuWdbhweIwPMO6WcT6GG7dmH wl78HqsASFAEfJRlCFE9ngLw0Ywhov1lzTq4ci1hP5Q2CGA1k3maMLwIjpJf5zULti0F 3JdtJlNtpqYChNt59g3kVQsPGBB1r0HBDgk7O0emTvLJIWdLmpFTkkSgsB3u3XqnQK3t l+3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qc4si4269702ejb.661.2021.05.28.00.43.35; Fri, 28 May 2021 00:43:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235893AbhE1H2X (ORCPT + 99 others); Fri, 28 May 2021 03:28:23 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50276 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235823AbhE1H2V (ORCPT ); Fri, 28 May 2021 03:28:21 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1lmWtH-0003eI-JE; Fri, 28 May 2021 15:26:43 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1lmWtH-0001zZ-E6; Fri, 28 May 2021 15:26:43 +0800 Date: Fri, 28 May 2021 15:26:43 +0800 From: Herbert Xu To: YueHaibing Cc: mpm@selenic.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] hwrng: core - Use DEVICE_ATTR_ macro Message-ID: <20210528072643.GI7392@gondor.apana.org.au> References: <20210520135713.32464-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520135713.32464-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, May 20, 2021 at 09:57:13PM +0800, YueHaibing wrote: > Use DEVICE_ATTR_RW()/DEVICE_ATTR_RO() helper instead of > plain DEVICE_ATTR, which makes the code a bit shorter and > easier to read. > > Signed-off-by: YueHaibing > --- > drivers/char/hw_random/core.c | 36 +++++++++++++++-------------------- > 1 file changed, 15 insertions(+), 21 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt