Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] crypto: algboss - Replaced simple_strtol() with
 kstrtouint()
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Biggers <ebiggers@kernel.org>
References: <20210524120834.1580343-1-liushixin2@huawei.com>
 <YKwhXlrJzdOjS9lJ@gmail.com> <20210603081238.GA1160@gondor.apana.org.au>
CC:     "David S. Miller" <davem@davemloft.net>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From:   Liu Shixin <liushixin2@huawei.com>
Message-ID: <cbb52d9a-af7a-b920-0471-1efe0ee480e2@huawei.com>
Date:   Thu, 3 Jun 2021 18:53:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20210603081238.GA1160@gondor.apana.org.au>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/6/3 16:12, Herbert Xu wrote:
> On Mon, May 24, 2021 at 02:57:50PM -0700, Eric Biggers wrote:
>> It would be better to just remove all the code related to CRYPTOA_U32 and
>> crypto_attr_u32, as it is never used.
> I agree, it's been unused for over a decade.
>
> Thanks,

Thank you both for the advice, I will fix it.
Besides, I noticed that type CRYPTOA_UNSPEC has never been used, should I remove it together?

Thanks,