Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: pTu0ukoWtJVcVuSMX8IJFOAzPeXbOshByG39Zv2U+WQl6G9CdL2aVdgmkvVNxsU2eagUPV1dtT
 /REH+gy+5WIg==
IronPort-SDR: 0K1zRFw7Kvnci8FIIPpPntvf+KhEq1euNVVcNii6lQQYXuvUN4qZXybAQbdmMZ9Nt12gxz9u+p
 d7f+SAtKzazQ==
From:   "Chiappero, Marco" <marco.chiappero@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        qat-linux <qat-linux@intel.com>,
        "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
Subject: RE: [PATCH 02/10] crypto: qat - remove empty sriov_configure()
Thread-Topic: [PATCH 02/10] crypto: qat - remove empty sriov_configure()
Thread-Index: AQHXUyxkPjTVKfPMokqNd4aL6CTqDqsCPfmAgAFa9VA=
Date:   Fri, 4 Jun 2021 09:23:28 +0000
Message-ID: <MN2PR11MB4598B0D816F3C31B1C45595FE83B9@MN2PR11MB4598.namprd11.prod.outlook.com>
References: <20210527191251.6317-1-marco.chiappero@intel.com>
 <20210527191251.6317-3-marco.chiappero@intel.com>
 <20210603121537.GA2062@gondor.apana.org.au>
In-Reply-To: <20210603121537.GA2062@gondor.apana.org.au>
Accept-Language: en-IE, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d5146612-5e82-4dff-5834-08d9273a6989
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2021 09:23:28.0686
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W5GRbbYRP2v5IFmoaLRweoS6GgZykb6StRu8R1oG0drjUo7G9KP/A4QdBgmtpmZkNvjpD59yGDF/AINTQY68l0+LDpnMr0sVvdtWJbsk5Hc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2962
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Thursday, June 3, 2021 1:16 PM
> To: Chiappero, Marco <marco.chiappero@intel.com>
> Cc: linux-crypto@vger.kernel.org; qat-linux <qat-linux@intel.com>; Cabidd=
u,
> Giovanni <giovanni.cabiddu@intel.com>
> Subject: Re: [PATCH 02/10] crypto: qat - remove empty sriov_configure()
>=20
> On Thu, May 27, 2021 at 08:12:43PM +0100, Marco Chiappero wrote:
> > Remove the empty implementation of sriov_configure() and set the
> > sriov_configure member of the pci_driver structure to NULL.
> > This way, if a user tries to enable VFs on a device, when kernel and
> > driver are built with CONFIG_PCI_IOV=3Dn, the kernel reports an error
> > message saying that the driver does not support SRIOV configuration
> > via sysfs.
> >
> > Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
> > Co-developed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> > ---
> >  drivers/crypto/qat/qat_4xxx/adf_drv.c          | 2 ++
> >  drivers/crypto/qat/qat_c3xxx/adf_drv.c         | 2 ++
> >  drivers/crypto/qat/qat_c62x/adf_drv.c          | 2 ++
> >  drivers/crypto/qat/qat_common/adf_common_drv.h | 5 -----
> >  drivers/crypto/qat/qat_dh895xcc/adf_drv.c      | 2 ++
> >  5 files changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/crypto/qat/qat_4xxx/adf_drv.c
> > b/drivers/crypto/qat/qat_4xxx/adf_drv.c
> > index a8805c815d16..b77290d3da10 100644
> > --- a/drivers/crypto/qat/qat_4xxx/adf_drv.c
> > +++ b/drivers/crypto/qat/qat_4xxx/adf_drv.c
> > @@ -309,7 +309,9 @@ static struct pci_driver adf_driver =3D {
> >  	.name =3D ADF_4XXX_DEVICE_NAME,
> >  	.probe =3D adf_probe,
> >  	.remove =3D adf_remove,
> > +#ifdef CONFIG_PCI_IOV
> >  	.sriov_configure =3D adf_sriov_configure,
> > +#endif
>=20
> How about #defining adf_sriov_configure to NULL?
=20
OK, looks good to me.

Best regards,
Marco