Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Jun 2021 18:14:39 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andre Przywara <andre.przywara@arm.com>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Will Deacon <will@kernel.org>, Ali Saidi <alisaidi@amazon.com>
Subject: Re: [PATCH] hwrng: Add Arm SMCCC TRNG based driver
Message-ID: <20210604171439.GA39696@sirena.org.uk>
References: <20210604170216.4705-1-andre.przywara@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L"
Content-Disposition: inline
In-Reply-To: <20210604170216.4705-1-andre.przywara@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--FCuugMFkClbJLl1L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 04, 2021 at 06:02:16PM +0100, Andre Przywara wrote:

> +static int __init smccc_trng_dev_init(void)
> +{
> +	platform_device_register_simple("smccc_trng", -1, NULL, 0);
> +
> +	return 0;
> +}
> +
> +device_initcall(smccc_trng_dev_init);

This will leave the device registered if the driver is removed and cause
the attempt to register the device again to fail if the module is
reloaded.  We don't check the error here but I'm not sure the driver
core won't complain about that and it's generally icky, better to clean
up the device on module removal.

--FCuugMFkClbJLl1L
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmC6X34ACgkQJNaLcl1U
h9BBVQf/XQdxBvCAtkGB0q2r1SwBLIFxttR/4U1G2b30Z2V0EeHjbDa3guGVMoe6
u/py83JO8RdTaFIDUgpJVTSn4YEQ49Jmw+zTng51oDEu/Jdkp390mYZ2+jnPzt6R
PezUOOaD5P5mSPlEhZLSb9cSBlU60aFHIFcpjK11F5jechFsGz0H2g9mNN7AU7rH
GR2CjCliZpkJsTG9ZTmd2tJMJqTRcU+KT/D/yw1+ynpMTXBaV6hrUduiD4E2VSs4
2+rstDlKGZcwl8Rnz8DMum8c1uP0W/21yQYK2jmC72H+yDsyMlBJ291bqh//pQPn
Qszkn3otjj3IL+Zg4JhoLzRxHenW3w==
=LpY4
-----END PGP SIGNATURE-----

--FCuugMFkClbJLl1L--