Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        linux-crypto@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>, tony.luck@intel.com,
        npmccallum@redhat.com
Subject: Re: [PATCH Part1 RFC v3 02/22] x86/sev: Define the Linux specific
 guest termination reasons
To:     Venu Busireddy <venu.busireddy@oracle.com>
References: <20210602140416.23573-1-brijesh.singh@amd.com>
 <20210602140416.23573-3-brijesh.singh@amd.com> <YL+T7X/417sQAUUA@dt>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <919c9acc-2d83-be24-d0d3-4d54851ff049@amd.com>
Date:   Tue, 8 Jun 2021 11:51:18 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
In-Reply-To: <YL+T7X/417sQAUUA@dt>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SN7PR04CA0215.namprd04.prod.outlook.com (2603:10b6:806:127::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Tue, 8 Jun 2021 16:51:19 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 18b81ab5-d6eb-4e3f-280e-08d92a9da4a2
X-MS-TrafficTypeDiagnostic: SA0PR12MB4509:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SA0PR12MB4509BA865EC4D958A106410EE5379@SA0PR12MB4509.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2657;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: weS0vFzZN4qDV15Vsyq5Co6G14Ux+eOnGVpbl3VGEsoRB2VJXQo6dItTZGUopdh3u4wtSwKK5Mr8bY7ZnpSbNbw/ueo2tCqTJrSx9jS88pDNifAxZai3NCMwzvq2CeOjiJJHTNFJJpo9I+QuiFAL/mSFjMzJ4TQg4oeyFH9k4T/9sGiM7w4Z4VDIxttOo0MAsSlTT+CmnjXX2oHwb3mqcz4bjhbWbg3vp9b2ZDhtPDk3ZpRd/VH9t2jOC1ZhUlclNTtlWxfV43u6/VxznMUoIvuAXbjCSPbcWjVLoFc5rACJxfEzcP/BjntNuePcdHDXfiselKQOlu2SvwT/CwG1G0syuGrUQHMzsvOE+b9E/8lsBlcLXExAC+nHcSnD0laRGpqiPyQAS5zqsGUI5gehUUHFsjnsb9+NP0teOTz+G/2H4Mj1QG97UexX2OqZmF2jFODI3RWHUF5aqkz1Rn+E8z8V1JkkDrmAPQfO9bR7Jg4whUfvXvbMaQZ0HxFkaAkWbM+vVA13iqDVdVPeVp3MyVAy2dp7VXi2GOYrKSRJyxtQRzFq1tnGZqFMFIfRpw+8hYuWrce10wnow8Nd5ro/Dw6sfhwUK3oDJwYIUaV2hc9b7REIZYTm44b9lOqzvMUpG9BBhUPqCpSnYlgKYLIgxfDv3/9fKrN2o4iW0m6p441NkxXozo8JL7JPGwzlKOXYdT57fT7dGySSaD/y0puQLRaSjO4B7L2o9AUl7LJm+mc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(83380400001)(31686004)(36756003)(5660300002)(6486002)(86362001)(8936002)(52116002)(53546011)(31696002)(6512007)(186003)(38350700002)(38100700002)(6916009)(2616005)(66556008)(66946007)(66476007)(44832011)(956004)(26005)(54906003)(7416002)(316002)(4744005)(2906002)(8676002)(16526019)(478600001)(6506007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmJUZ0owR2xCdWhmaTJRRE1XZlFKaThQak44bUlCMUZRU0l1Yy9rZ1RPSVBa?=
 =?utf-8?B?WVU0ZlFzYTR5OXB0TVJxQ1c4UDZzbXZ4NEdPTWZsR0VOb05wNGduU25UTFlw?=
 =?utf-8?B?T2NvUUs5U0lQeDFFTHlyMUtmZzlVZ0J4V1cxNWg0Wjg0YzVRWjdWT3ZrcEVL?=
 =?utf-8?B?M1pOcE4rbjJwVFlLMmVuOFlTaXFlUnoyNGVGaDlYYWlJcHhucWhRams2RWcw?=
 =?utf-8?B?WDRoSFBSVzBPNk9DZkdQV3JENVVuNE5LNnluZGo3Mm16UkVIdjJKZ3pldkRz?=
 =?utf-8?B?NGNaMmVRcVMyRG1hNkF4WXB3U3l0dllnbzRhZnRIeTcxbGZ5TEtlcnlENStH?=
 =?utf-8?B?MzAwWXVJa3JjS1Jla0x5bkdzRmZ4dDBCYjJxV2RvaGV5SGRqWE95M2pnT3k3?=
 =?utf-8?B?RjNYWVZVT2k2eWthVUdGekxNSUw2Zm5XbFpjM3FKakpPMWRWQ3JWNVhMU1FP?=
 =?utf-8?B?VFBCT3d6V0pYdGFVdDNlWGpIZHBzSWF1NERmQlFMQ3F3V0tsK2o1SGlvRE1O?=
 =?utf-8?B?SktFV1ppWWlhR1VIV3ZoSjhmU0tJQmdIQVFLOHErdDlZUWMrRCtreE5DSGth?=
 =?utf-8?B?Qm84eFRqY2JFanpNMzhEY2VUcmlnY1BMQ1pscEtlVk03WHJmYnpDUEFEK1Z1?=
 =?utf-8?B?VWp3RGpMZUJISTJQTGNiOXg3RXlyM3Nodk13VktXN1plLytrQWhSZGxyYXBk?=
 =?utf-8?B?L1dtR3liU3UvUy92Z1U3Ymh1dUxlbHMvU2twTEpCblBxeHpyRWZwOXhXSmNj?=
 =?utf-8?B?VzBmMzVxU0tNaGN3cURUclMyK2RPblBBRFNLTkYrOEtlMXdyeXBlUjlxVUJ5?=
 =?utf-8?B?N2VUeDZKaFR0eVpZT0JnOHBhNkFXbkFJSmRpaFEwY1VxNmo1VndnVEw3VkVn?=
 =?utf-8?B?aWsxNmxBR0VtdWtpRkcrTlZYSitwQ3lyNFU5UzBiMjFaZVREWTVJUm8wWHpV?=
 =?utf-8?B?V3JCdnhIRGp6S2EzQ3Vna2tQVnVleGZIRkpjaTR1Qk9xa05NZ3NqWXFsRnV4?=
 =?utf-8?B?amU4QWpKejFyYURQMEI4WHUxRnFHMTBINUR3dlIrV0xBYm15QVp0NDV0c0hw?=
 =?utf-8?B?RHVLbTJncFpCZE1BTDhBdHJ4Y0c4Z2RmU292SGt1MkhSLzV2YlNOa25jRWdu?=
 =?utf-8?B?cTN3UE1BMXpmSE5TS3R1UWJRbG1Hc1dZN0ZRa1hqZW84djVSRUhvK1ZMZW8w?=
 =?utf-8?B?a1pRRWpsUUJxUG5CWDhaUHgyL3MyWkNtdDNmQld1Q3FsNG9xUGE0eE5zdFl4?=
 =?utf-8?B?ZWFCVWsxR0hVTmN1UE1XaWh4Vm82cWtWaklKVTAxWmlXL3RvMmV6QzRNM0hO?=
 =?utf-8?B?aDcxdVIwN293VjFFVVVlclBGVXJqQkFWNVFONDlPMEx4M2FtbTZCcGNPaEN6?=
 =?utf-8?B?Y2JzalVHOGthWjlKQ3QxR3hVbWlxb2d3ekZGVXd0Y2p3MlkwYzA0VnFTeUov?=
 =?utf-8?B?RTliaTVkb1dGcmNxYmFjclNFSGMzK0FhM2NtVTlqWDk5bTMyZ0g1TStwcUZs?=
 =?utf-8?B?OFVxd0txdGRZSE1YQ29VS3piZCtKOHRVZGxEOHVvMzNqeDdOQk41RGRKYUxi?=
 =?utf-8?B?N0dVVC9pajBkZzA1SXF1aENNa3hkdmJlOTRlWFRGVDhxOXFYZDZhQ0hJemxK?=
 =?utf-8?B?NFJBVzl0Mjg1WjBSMFkwdFJ1aHhFN3R4c2N1WlhjbzN5enlDRGxUNjV1N2Z5?=
 =?utf-8?B?VHBTa2szeng2YnZJczZkWnh0VHcyazdiNWU3SnhvSjY0b2ViaEx3RFlmc0wy?=
 =?utf-8?Q?DlbzbMdnY+jlRSjEBq0q22Evayt4MgYfIhB0NSW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18b81ab5-d6eb-4e3f-280e-08d92a9da4a2
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2021 16:51:21.1777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VjRC+Ila+V98iGETVvF/z7jjVuUhnlfc501NwELf2s6rEQGgmjMhZYM8302PNskanoVwmfEMjoiEMNtefDPXrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4509
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 6/8/21 10:59 AM, Venu Busireddy wrote:
>
>>  {
>>  	u64 val = GHCB_MSR_TERM_REQ;
>>  
>> @@ -32,7 +32,7 @@ static void __noreturn sev_es_terminate(unsigned int reason)
>>  	 * Tell the hypervisor what went wrong - only reason-set 0 is
>>  	 * currently supported.
>>  	 */
> Since reason set 0 is not the only set supported anymore, maybe the part
> about reason set 0 should be removed from the above comment?

Sure, I will update the comment. thanks