Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp349959pxj; Fri, 11 Jun 2021 00:20:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5kTqFtVZlw0v9gy+AE81iYA9xPvuy0d9+pULzU+o/3Wkqb9B6dBlc4t25uuZYDzmKfyzk X-Received: by 2002:aa7:db90:: with SMTP id u16mr2236259edt.106.1623396007947; Fri, 11 Jun 2021 00:20:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623396007; cv=none; d=google.com; s=arc-20160816; b=rxCJIbumFenSqNHpWX5OFiPoY+WfsgGbElIaayvYkM+ahSsEH9igFMU8pCBZGRr0xU RSWmkVaTUQLJ2p/6gUvZKfPy0idbA0hJckFFlpnydenNgldXy59FEZU2u0wInog56lj3 CyNG0610OunVR/ioDT8P1UuZsiSMjeDVi6uQ7bQTcOAhqyHyKDKHS95vdDtF3EBqwDy6 3+9fJ3/LaDUOQ0ToecCK7buEFkD84O099TIF8kQDeaIxi7a1AJQHngsXwtqrvOj8dx8M O1Aw+1w0dZn6TAGYQrXOopsW0+MFkFJOQ72QtErVmpLWRKG0PKiACb/JClCwQrebkKlF ViHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=bk+hRR/ktrAkLRZCiStTKj7rX3nLlMlstMWdVguEUVQ=; b=pirkULmUPuAeLqwBvtjHSDQfqST7Lmdy5nGUl75AXFaqbS9f7xJKDE8mCrUKPzRzx5 lP4QfiLYWHfJUKrY8Cl97dS9J0Rxqonip0rHHm1lyeg6LdzzGAnbJVOCuaeAvdThcZiX YivheNcVswYoxfzv8KPjDIS3tsdCEiXCHzywg7hoiS7i5LpqjGmRyUwmL0lxcAyBpUNc gzu8P9tlKEiuDB8Xtk2ldz//q5JqIZJRd0xfx3ZyXAPUQ39o/eWPuEMw2E/mHxh5ODta EOuVgo7OCRWi1nPAYexparMSwhm5mFbRv5JBsrEfPHqWD+mbjxYIC+D60PBUGyb1EJTb vVhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o13si5222117ejb.722.2021.06.11.00.19.44; Fri, 11 Jun 2021 00:20:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230370AbhFKHUO (ORCPT + 99 others); Fri, 11 Jun 2021 03:20:14 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50550 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhFKHUO (ORCPT ); Fri, 11 Jun 2021 03:20:14 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1lrbQX-0005A7-Ly; Fri, 11 Jun 2021 15:18:01 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1lrbQ6-0002Kj-2m; Fri, 11 Jun 2021 15:17:34 +0800 Date: Fri, 11 Jun 2021 15:17:34 +0800 From: Herbert Xu To: Corentin Labbe Cc: davem@davemloft.net, linus.walleij@linaro.org, linux@armlinux.org.uk, robh+dt@kernel.org, ulli.kroll@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] crypto: add gemini/sl3516 crypto driver Message-ID: <20210611071733.GC23016@gondor.apana.org.au> References: <20210601151132.1893443-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210601151132.1893443-1-clabbe@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 01, 2021 at 03:11:27PM +0000, Corentin Labbe wrote: > The gemini SL3516 SoC has a crypto IP. > This serie had support for it. > > It was tested with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. > Furthermore, it survives hours and gigs of write/read to a luks2 using xts(ecb-aes-sl3516). > > Performance is quite good. > On a luks2 partition (2To with bs=4096), a fsck comes from 14m26(without CE) to 8m48(with CE). > So it is really usefull. > > With bs=512, the performance is similar with software. > > Changes since v1: > - reworded dt-binding subject patch > - fixed build with CRYPTO_DEV_SL3516_DEBUG > > Corentin Labbe (5): > dt-bindings: crypto: Add documentation for sl3516-ce > crypto: Add sl3516 crypto engine > ARM: dts: gemini: add crypto node > ARM: gemini_config: enable sl3516-ce crypto > MAINTAINERS: add gemini crypto sl3516-ce > > .../crypto/cortina,sl3516-crypto.yaml | 50 ++ > MAINTAINERS | 7 + > arch/arm/boot/dts/gemini.dtsi | 8 + > arch/arm/configs/gemini_defconfig | 1 + > drivers/crypto/Kconfig | 19 + > drivers/crypto/Makefile | 1 + > drivers/crypto/gemini/Makefile | 2 + > drivers/crypto/gemini/sl3516-ce-cipher.c | 388 +++++++++++++ > drivers/crypto/gemini/sl3516-ce-core.c | 535 ++++++++++++++++++ > drivers/crypto/gemini/sl3516-ce-rng.c | 61 ++ > drivers/crypto/gemini/sl3516-ce.h | 347 ++++++++++++ > 11 files changed, 1419 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/cortina,sl3516-crypto.yaml > create mode 100644 drivers/crypto/gemini/Makefile > create mode 100644 drivers/crypto/gemini/sl3516-ce-cipher.c > create mode 100644 drivers/crypto/gemini/sl3516-ce-core.c > create mode 100644 drivers/crypto/gemini/sl3516-ce-rng.c > create mode 100644 drivers/crypto/gemini/sl3516-ce.h Patches 1,2,5 applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt