Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp600363pxj; Thu, 17 Jun 2021 09:29:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/0k0POPAjSRdHilHEa20wHoSNCbitQojNYwFFuEgiLhJmbfqhFp0S555z1L2yBK12Gdp1 X-Received: by 2002:a17:906:994d:: with SMTP id zm13mr6053767ejb.427.1623947394318; Thu, 17 Jun 2021 09:29:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623947394; cv=none; d=google.com; s=arc-20160816; b=gJqQ2vi4BXK7hujf1eZY01BdcoLoUHiIeZHRoZRJniDK/nAxU1qgwU06i63I2OADzs AMlTa4p8LyL5bJHmnrPb3unjWhPe4TaJEnwZ+3hiyxbOgL+O61JoeeqpwTZxUBA3119k QhTsPwNrARAyqlNsMJEKi7MK6LbnSB6UjdVK8R2QyRUpHWzTTGCAPlVpohu273csHzh7 xYTihV6E+B56Ham/6y7qa9+VvIBsRxLcKb+rIY5ugKv9m/tsJ5pfrG0WbUkguSIlkG32 MMKv9LGGO5lM1c31hta5S+myByyMXEHVW7x6QkCLbxBN2NWzH9UVodZjZOFmniYPAogs kX3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=LVkWEpy5e6cRZkuXdEoUXgk9+WHo500mtyYaCdD+Lf0=; b=JsKh1J5XZhl3pIcm3aKLtCz1h8oRcZYnt8zF/X1gpTo52eGjzbu1CPPmUT00HegdyQ melXehVwXiyaa6RM50kg31YQ2smKTj/0/7jiMjSE0903mZjXiZ0BI+zjwKhgzO2Crz2i XmGM0ag9lOQjKt9PAWvtcBXHs8nX3VjDIpv9B2i2k/Hg3CtPoOLP1hh+BJG9aaUUJY4z ZlqR+NoDgtb+cBR2/uz/tRrfn3Vu0ApnLERYCrCev2pmIiIuu4weSBp2fGI9++0Jb9mM eD5n6ZvxpHdy/PyZnRmXzgv40jGFtfMw+RuknbJiSV25G2J0ZBGFRrN7uOyGpqhu6sEL usmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=jeALzHLk; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si5768681edb.340.2021.06.17.09.29.24; Thu, 17 Jun 2021 09:29:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=jeALzHLk; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233829AbhFQQK6 (ORCPT + 99 others); Thu, 17 Jun 2021 12:10:58 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:37854 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233682AbhFQQKB (ORCPT ); Thu, 17 Jun 2021 12:10:01 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15HG62FL083373; Thu, 17 Jun 2021 11:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623945962; bh=LVkWEpy5e6cRZkuXdEoUXgk9+WHo500mtyYaCdD+Lf0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jeALzHLk3n7+qQeuxED/H4L5B0pUGfd+IKm4cHUnNDcbGNi/N/vECD6HccgWs8Rdc A79ZIeBKglC2uQcNptT6Rqq9rI3jaHqWmNvG1vKe80Rl9RF+rCyfhlpGUEyO1JBVae q2yQKhqF9u2BVEw+7gi7jwzlSE7Jbm56DgmZH8PQ= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15HG60jb058606 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Jun 2021 11:06:01 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 17 Jun 2021 11:06:00 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 17 Jun 2021 11:06:00 -0500 Received: from [10.250.36.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15HG5xDj116986; Thu, 17 Jun 2021 11:05:59 -0500 Subject: Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems To: Rob Herring , CC: Andrew Lunn , , Daniel Lezcano , Alexandre Belloni , Guenter Roeck , , , Linus Walleij , Wim Van Sebroeck , , Ulf Hansson , , , , , , Lee Jones , , , Lars-Peter Clausen , Herbert Xu , Bartosz Golaszewski , Marc Zyngier , Jassi Brar , Vinod Koul , Kishon Vijay Abraham I , David Airlie , , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Jakub Kicinski , Zhang Rui , Vivien Didelot , Wolfgang Grandegger , , Ohad Ben-Cohen , , Albert Ou , , , , , Mark Brown , Marc Kleine-Budde , Kamal Dasu , Paul Walmsley , Bjorn Helgaas , Krzysztof Kozlowski , Thomas Gleixner , Mauro Carvalho Chehab , , Jens Axboe , Alessandro Zummo , Mathieu Poirier , Stephen Boyd , , Philipp Zabel , , , , , , Palmer Dabbelt , , Daniel Vetter , Greg Kroah-Hartman , , Vladimir Oltean , "David S. Miller" , Jonathan Cameron References: <20210615191543.1043414-1-robh@kernel.org> From: Suman Anna Message-ID: Date: Thu, 17 Jun 2021 11:05:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210615191543.1043414-1-robh@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Rob, On 6/15/21 2:15 PM, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Vinod Koul > Cc: Bartosz Golaszewski > Cc: Kamal Dasu > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Jassi Brar > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Ulf Hansson > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Vladimir Oltean > Cc: Bjorn Helgaas > Cc: Kishon Vijay Abraham I > Cc: Linus Walleij > Cc: "Uwe Kleine-König" > Cc: Lee Jones > Cc: Ohad Ben-Cohen > Cc: Mathieu Poirier > Cc: Philipp Zabel > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Mark Brown > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 1 - > .../devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml | 2 -- > .../devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 1 - > Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml | 2 -- > .../devicetree/bindings/clock/qcom,gcc-sm8350.yaml | 2 -- > .../devicetree/bindings/clock/sprd,sc9863a-clk.yaml | 1 - > .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 2 -- > Documentation/devicetree/bindings/crypto/fsl-dcp.yaml | 1 - > .../display/allwinner,sun4i-a10-display-backend.yaml | 6 ------ > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 1 - > .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 ---- > .../bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml | 2 -- > .../bindings/display/allwinner,sun8i-r40-tcon-top.yaml | 2 -- > .../devicetree/bindings/display/bridge/cdns,mhdp8546.yaml | 2 -- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 2 -- > Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- > .../devicetree/bindings/display/st,stm32-ltdc.yaml | 1 - > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 ---- > .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > .../devicetree/bindings/edac/amazon,al-mc-edac.yaml | 2 -- > Documentation/devicetree/bindings/eeprom/at24.yaml | 1 - > Documentation/devicetree/bindings/example-schema.yaml | 2 -- > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 - > Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 1 - > Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml | 1 - > .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 2 -- > .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml | 1 - > .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- > .../bindings/interrupt-controller/fsl,irqsteer.yaml | 1 - > .../bindings/interrupt-controller/loongson,liointc.yaml | 1 - > Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml | 1 - > .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 - > .../devicetree/bindings/mailbox/st,stm32-ipcc.yaml | 2 -- > .../devicetree/bindings/media/amlogic,gx-vdec.yaml | 1 - > Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 1 - > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 1 - > .../devicetree/bindings/media/qcom,sc7180-venus.yaml | 1 - > .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 1 - > .../devicetree/bindings/media/qcom,sm8250-venus.yaml | 1 - > Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 - > .../bindings/memory-controllers/mediatek,smi-common.yaml | 6 ++---- > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 1 - > .../devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml | 2 -- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 - > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 -- > Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 -- > Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 1 - > Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml | 1 - > .../devicetree/bindings/net/amlogic,meson-dwmac.yaml | 2 -- > .../devicetree/bindings/net/brcm,bcm4908-enet.yaml | 2 -- > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 2 -- > Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml | 2 -- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 -- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 1 - > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 -- > Documentation/devicetree/bindings/pci/loongson.yaml | 1 - > .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 1 - > .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 -- > Documentation/devicetree/bindings/perf/arm,cmn.yaml | 1 - > .../devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml | 1 - > .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 3 --- > Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 1 - > Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 2 -- > .../devicetree/bindings/phy/phy-cadence-sierra.yaml | 2 -- > .../devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 ---- > .../devicetree/bindings/phy/qcom,ipq806x-usb-phy-hs.yaml | 1 - > .../devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml | 1 - > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 - > Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 2 -- > Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml | 2 -- > Documentation/devicetree/bindings/phy/renesas,usb3-phy.yaml | 1 - > .../devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml | 1 - > .../devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml | 1 - > .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 1 - > .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml | 2 -- > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 1 - > .../devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml | 1 - > Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 1 - > .../devicetree/bindings/riscv/sifive-l2-cache.yaml | 1 - > .../devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 1 - > Documentation/devicetree/bindings/rtc/imxdi-rtc.yaml | 1 - > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 2 -- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 1 - > .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 1 - > Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 2 -- > .../bindings/sound/nvidia,tegra-audio-graph-card.yaml | 1 - > .../devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 2 -- > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 3 --- > .../devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml | 1 - > .../devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml | 2 -- > .../bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 2 -- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 - > .../bindings/timer/allwinner,sun5i-a13-hstimer.yaml | 1 - > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 1 - > .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 -- > .../devicetree/bindings/timer/intel,ixp4xx-timer.yaml | 1 - > .../devicetree/bindings/usb/maxim,max3420-udc.yaml | 2 -- > .../devicetree/bindings/usb/nvidia,tegra-xudc.yaml | 4 ---- > Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 --- > .../devicetree/bindings/watchdog/st,stm32-iwdg.yaml | 1 - > 101 files changed, 2 insertions(+), 163 deletions(-) > [snip] > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > index 6070456a7b67..f399743b631b 100644 > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > @@ -57,7 +57,6 @@ properties: > > memory-region: > minItems: 2 > - maxItems: 8 > description: | > phandle to the reserved memory nodes to be associated with the remoteproc > device. There should be at least two reserved memory nodes defined. The Does this enforce the maxItems to be 2 only now? Or should this be dropping the minItems here which matches the length of items instead of maxItems? I have originally listed the individual item list only for the mandatory items and rest are scalable. I provided this through "additionalItems: true" under this property. Also, have the exact same usage in Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml as well which is not included in this patch. > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml > index 73400bc6e91d..75161f191ac3 100644 > --- a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml > @@ -116,7 +116,6 @@ properties: > list, in the specified order, each representing the corresponding > internal RAM memory region. > minItems: 1 > - maxItems: 3 > items: > - const: l2ram > - const: l1pram [snip] > diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > index dbc62821c60b..9790617af1bc 100644 > --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > @@ -100,7 +100,6 @@ patternProperties: > properties: > reg: > minItems: 2 # On AM437x one of two PRUSS units don't contain Shared RAM. > - maxItems: 3 > items: > - description: Address and size of the Data RAM0. > - description: Address and size of the Data RAM1. > @@ -111,7 +110,6 @@ patternProperties: > > reg-names: > minItems: 2 > - maxItems: 3 > items: > - const: dram0 > - const: dram1 regards Suman