Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Chanho Park" <chanho61.park@samsung.com>
To:     "'Dominique MARTINET'" <dominique.martinet@atmark-techno.com>,
        "'Jianxiong Gao'" <jxgao@google.com>
Cc:     "'Christoph Hellwig'" <hch@lst.de>,
        "'Konrad Rzeszutek Wilk'" <konrad@darnok.org>,
        "'Konrad Rzeszutek Wilk'" <konrad.wilk@oracle.com>,
        "'Linus Torvalds'" <torvalds@linux-foundation.org>,
        =?utf-8?Q?'Horia_Geant=C4=83'?= <horia.geanta@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        "'Lukas Hartmann'" <lukas@mntmn.com>,
        "'Aymen Sghaier'" <aymen.sghaier@nxp.com>,
        "'Herbert Xu'" <herbert@gondor.apana.org.au>,
        "'David S. Miller'" <davem@davemloft.net>,
        <linux-crypto@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
        "'Marc Orr'" <marcorr@google.com>,
        "'Erdem Aktas'" <erdemaktas@google.com>,
        "'Peter Gonda'" <pgonda@google.com>,
        "'Bumyong Lee'" <bumyong.lee@samsung.com>
In-Reply-To: <YM/zWyZlk1bzHWgI@atmark-techno.com>
Subject: RE: swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb)
 stable/for-linus-5.12)
Date:   Mon, 21 Jun 2021 11:55:22 +0900
Message-ID: <2038148563.21624247281621.JavaMail.epsvc@epcpadp4>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFDXrbxzNqCjAFYIyZp8SJPpEE7BALklUvQAU7mhF0BiRUMkQElteCnAXJthq8BvQCqOAH1sv7OAe2NoSYCTMPpJQDVyVEXAhuWClmrrDnekA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
References: <YL7XXNOnbaDgmTB9@atmark-techno.com>
        <2e899de2-4b69-c4b6-33a6-09fb8949d2fd@nxp.com>
        <20210611062153.GA30906@lst.de> <YMM8Ua0HMmErLIQg@0xbeefdead.lan>
        <CAMGD6P1v2JoJoxSuAYL8UjdtCaLCc4K_7xzVkumspeb0qn=LBQ@mail.gmail.com>
        <YMqW+/gQvM+uWUTw@fedora> <YMqZswFnSNKk4Z7B@atmark-techno.com>
        <20210617051232.GB27192@lst.de> <YMrfWBLsJxCRhX5U@atmark-techno.com>
        <CAMGD6P0=9RE1-q1WHkwR1jymK5jyvN6QgypQ2KgdvBQn0CUTHw@mail.gmail.com>
        <CGME20210621020328epcas2p207e9fa2df119730ceb993543621437d8@epcas2p2.samsung.com>
        <YM/zWyZlk1bzHWgI@atmark-techno.com>
Precedence: bulk

+ Bumyong who is the original author of the patch.=20

Hi Dominique,

> Thanks!
> (a bit late, but added Chanho Park in Cc...)
>=20
> I can confirm it also works for our caam problem, as Horia said.
>=20
> I've also come to term with the use of swiotlb_align_offset() through
> testing, or rather many devices seem to have a 0 mask so it will almost
> always be cancelled out, so if it works for Jianxiong then it's probably
> good enough and I'll just assume that's how the orig_addr has been
> designed...
>=20
> I think it's missing a couple of checks like the one Linus had in his
> patch, and would be comfortable with something like the attached patch (i=
n
> practice for me exactly the same as the original patch, except I've added
> two checks: offsets smaller than orig addr offset are refused as well as
> offsets bigger than the mapping size)
>=20
> I'm sorry Jianxiong but would you be willing to take the time to test
> again just to make sure there were no such offsets in your case?
>=20
>=20
> If we're good with that I'll send it as an official v2 keeping Chanho's
> from, unless he wants to.
>=20

Sure. No problem. But, the patch was already stacked on Konrad's tree
and linux-next as well.

https://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git/commit/?=
h=3Ddevel/for-linus-5.14&id=3D33d1641f38f0c327bc3e5c21de585c77a6512bc6=20

Best Regards,=20
Chanho Park