Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5698121pxj; Wed, 23 Jun 2021 07:10:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+0VRN0wFsBKHhPviG73JDloo4WcQWcD6VQTfBZOf+kG+Sj7CRh/froR71ZgKVfgdMZHpR X-Received: by 2002:aa7:da8a:: with SMTP id q10mr12343988eds.81.1624457407563; Wed, 23 Jun 2021 07:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624457407; cv=none; d=google.com; s=arc-20160816; b=UyM9hwbHFkmC6NIk++RU1G7yvKYuxE//Rp7y9GaF+RABBHl7M1R0fc0gMETCxT6uZX mXjvnzjMORta3Z0yvj+QfSBqSabY//VIkPTlezASeXJrqTilLMB2u0KAA607p53PFkS0 W/XJjttXEsKb6kWcIvBzqQXS8O7hXecbVm/yrKDrnowrD3CWwghz2oCbfI9sDuuRuGcB YDJ8RFGk1nvWfVOc1Bj0sXFh3uoxGQ+j1JiRb7PSI9vMPuxphc282gBS1O2LgxSipbr6 w1mF+1as36ieNKeKxHJiO/5O7c9jBidc3DIGyIAeu5snA7cH8yIHBZpcpngDZXORx8yV J6Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=NRazLj1zAKWEN3EP+kSzvdhJ1lmy0btYt+IO4sTVQ2w=; b=y8Flv0Ve5HkaNz8poHbv/gsjONb2ihlAR0MWvTg+MaHj06MGp5yVg1Wjl61ZEdrP7L r8c9vkiBcwBKG6As7GVPDzNtD4WEvtRrM4tnav2y508Wh11IEZSopc1/1sbHKb+hwRnp 2eUAtoY7fQUwdBVBXbthBjAzHb7p1aY9ViWZoQuXzU5IwZSLE5IwJyaYH5PC5WyqYg8g hYivWkr0rzB7uwUsBDel2amCgLx05mimgp8uiD644Z0+9QYXrF5qNtCn7XZ/KB7uCE7t a7X8XURUIr+tbXjtDU7NJB3lf2iPKGXDCzMu8neLHvDwzbLJw/LuFeAu/Uno4qB/HqHd OPGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c14si23982048edm.54.2021.06.23.07.09.34; Wed, 23 Jun 2021 07:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbhFWOLA (ORCPT + 99 others); Wed, 23 Jun 2021 10:11:00 -0400 Received: from mga07.intel.com ([134.134.136.100]:16386 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230274AbhFWOLA (ORCPT ); Wed, 23 Jun 2021 10:11:00 -0400 IronPort-SDR: 4iBSV607JQCUAL8h7od7dwf7Grq1hpNWws7Bd3QtIaFTXqvD8StqOfGfpppcQN8Uf/jM0DoFvh bBgw9gUVZkiw== X-IronPort-AV: E=McAfee;i="6200,9189,10024"; a="271113513" X-IronPort-AV: E=Sophos;i="5.83,294,1616482800"; d="scan'208";a="271113513" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 07:08:40 -0700 IronPort-SDR: vYprr8R9IUpUo6IDIn7or13zowPRhoIFjSUSFNMl5HEjTyplSdILSjLsKZRD/txvBkuTaVIR0E HpjXIQlyGPFg== X-IronPort-AV: E=Sophos;i="5.83,294,1616482800"; d="scan'208";a="556155669" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314) ([10.237.222.51]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 07:08:38 -0700 Date: Wed, 23 Jun 2021 15:08:31 +0100 From: Giovanni Cabiddu To: Colin King Cc: Herbert Xu , "David S . Miller" , Qinglang Miao , qat-linux@intel.com, linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: qat: ratelimit invalid ioctl message and print the invalid cmd Message-ID: References: <20210622151608.23741-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622151608.23741-1-colin.king@canonical.com> Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 22, 2021 at 04:16:08PM +0100, Colin King wrote: > From: Colin Ian King > > Currently incorrect QAT ioctls can spam the kernel log with error messages > of the form "QAT: Invalid ioctl" if a userspace program uses the wrong > ioctl command. Quench the messages by ratelimiting them and also print > the invalid command being used as that is useful to know. > > Signed-off-by: Colin Ian King Just a minor comment on the commit message: crypto: qat: ratelimit invalid ioctl message and print ^ Patches to the qat driver have the following headline: crypto: qat - not crypto: qat: Apart from that Acked-by: Giovanni Cabiddu Regards, -- Giovanni