Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp979835pxv; Thu, 1 Jul 2021 13:59:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaJbQNdDefZgvGAwwZgbjIOKnPH+qwFhD4RevC0fQre/f9GErnA/cnn7iSROOheRRCmVVe X-Received: by 2002:a92:cdab:: with SMTP id g11mr996873ild.240.1625173141971; Thu, 01 Jul 2021 13:59:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625173141; cv=none; d=google.com; s=arc-20160816; b=hftKP3AH+k/IT3vgSmUvoABIcb5bsyRUEhFxRIIqcBv8WJUioTBPX2k7bYM8ejz3Ll wISqgiooIU+AfzQbKo2M9tbPQqzQ0xqwPJcajILOeiwDXpNwyg7hGKfX79VHC0tgZJmg Njr3Zqn7mNVt4n7bR1aPyp11pYTFlngyG45ERyMmOmdj3dVYTwcJA77bWfsN7jhek0i1 DadT7IEn/hiuucHS6Fy5QoVp5DQX0B+bvWBcDXyB03jQDhhG+sABNYQ7dvkNImKX6dqs 9IS09Dw/iSMGzHiIhQO3Ejh1mVSJb+jFSB2x6zDdIYuWl5q7Cvil3otTFEpFtddwt/lj rBzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=grqpFt25w8LL5h7sJfp5o8d+qOG/4MHuntPNYx5rYuw=; b=iHSAjsaWnRP0/rqpK+znUROhfhCn6njZxFUdsiRnCpl6WeeKemQ/WNozEsONHzoweA GEq+kkSdH0xjchR5S9kq0VsyMd23FeHongznteSgRI74tJ7PnhMN/DUaAPIFg1a1gfub gAUsqwAqo+hfWnURkI91Is6lj1sR2EItKry7SLVIY9JCbh2OjmcTOWry05Q1JLt8ofFp M4CjOAubr5+euBnq1ZeZF9lpfWVm9hrEx21gxnqPjGgDsVkfrIh0+GZGN1ELG8aJ78nQ kQJcx7QJvU6juD+bHKffa0Cz9D5mzpZAfwZzvShFjQ6ohRwKcneXiLjYeQOeKrv0fkiy DMfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a11si920117iln.136.2021.07.01.13.58.41; Thu, 01 Jul 2021 13:59:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234420AbhGAUpa convert rfc822-to-8bit (ORCPT + 99 others); Thu, 1 Jul 2021 16:45:30 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:51298 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230063AbhGAUp3 (ORCPT ); Thu, 1 Jul 2021 16:45:29 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 6216D6108476; Thu, 1 Jul 2021 22:42:56 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kLydErpcW5Ws; Thu, 1 Jul 2021 22:42:55 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id C39FC6108472; Thu, 1 Jul 2021 22:42:55 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LbgvkTJUFHdW; Thu, 1 Jul 2021 22:42:55 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 844066083273; Thu, 1 Jul 2021 22:42:55 +0200 (CEST) Date: Thu, 1 Jul 2021 22:42:55 +0200 (CEST) From: Richard Weinberger To: Ahmad Fatoum Cc: Jonathan Corbet , David Howells , Jarkko Sakkinen , James Bottomley , Mimi Zohar , kernel , James Morris , "Serge E. Hallyn" , horia geanta , aymen sghaier , Herbert Xu , davem , Udit Agarwal , Eric Biggers , Jan Luebbe , david , Franck Lenormand , Sumit Garg , "open list, ASYMMETRIC KEYS" , Linux Crypto Mailing List , Linux Doc Mailing List , linux-integrity , linux-kernel , LSM Message-ID: <1850833581.13438.1625172175436.JavaMail.zimbra@nod.at> In-Reply-To: <39e6d65ca5d2a0a35fb71d6c1f85add8ee489a19.1624364386.git-series.a.fatoum@pengutronix.de> References: <39e6d65ca5d2a0a35fb71d6c1f85add8ee489a19.1624364386.git-series.a.fatoum@pengutronix.de> Subject: Re: [PATCH v2 6/6] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF78 (Linux)/8.8.12_GA_3809) Thread-Topic: KEYS: trusted: Introduce support for NXP CAAM-based trusted keys Thread-Index: g8issG6CVMbkLEBHiev9vrinZL1Dqw== Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Ahmad, ----- Ursprüngliche Mail ----- > Von: "Ahmad Fatoum" > +static struct caam_blob_priv *blobifier; > + > +#define KEYMOD "kernel:trusted" I'm still think that hard coding the key modifier is not wise. As I said[0], there are folks out there that want to provide their own modifier, so it is not only about being binary compatible with other CAAM blob patches in the wild. I'll happily implement that feature after your patches got merged but IMHO we should first agree on an interface. How about allowing another optional parameter to Opt_new and Opt_load and having a key modifier per struct trusted_key_payload instance? Thanks, //richard [0] https://patchwork.kernel.org/project/linux-crypto/patch/319e558e1bd19b80ad6447c167a2c3942bdafea2.1615914058.git-series.a.fatoum@pengutronix.de/#24085397