Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4347773pxv;
        Mon, 5 Jul 2021 21:40:35 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJz2OEAUW20I93DRH5B4abfzF9kgK3NcWDdUDBxCBtV6mIg0nlfhmvOYWypSivnlRnHrqkBp
X-Received: by 2002:a17:907:d87:: with SMTP id go7mr902203ejc.280.1625546435726;
        Mon, 05 Jul 2021 21:40:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1625546435; cv=none;
        d=google.com; s=arc-20160816;
        b=kBhBBE1oZO+atDGA+m9X6ci8RqsHsGSDPtJUfn0kN34To7dviI2/dIJXXLK3vJTDAC
         adqseHF2FMt2Dkv4t1MtHGTXBqtn4QSC3GzjqVxPhiMOjbZ4USb162Eh31rOOjnye6MB
         OPBRG6OHqwrJVpBgCYWRfL0TTOK33UA2WZwjYx8+YYnmr2Iul4m1EJ250E8QH8FZXo/V
         yfvJXBRJQOlS984k/q9TaF1Q278q+buF5738AB7jGvlwMt3k6umodUJcW3E092xh2P3/
         8xTFZkYE6WlC18Wg1IhipXSwXh12IvaJJlWAmbY46P5Shwe1Vviy53/RtbMmR3oe4+bB
         +49A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=Tm9bbwSLIXHzncYHK7SPpmMxLf8Q613BrbD6KMaacCU=;
        b=kPj/z9goO/rq2n69fKDbeuwJPc8MGw34j9/kzPllDYcYwqlgLCXvAnjNaLNopzEBXY
         WSlxH6PVw4/v3nSe9BjMVQF7qniSj9HEsQQa6vJzYIC9Ur9JJtyPVZVrxq5vq+y4ieG7
         +MtuFC5C0YPQEDCDM5fsPSGKR61JwSKpD5bclNkp22hhvq4XOAsDlbXr8JBcpCdi9rTM
         CNsMB+UlVrkz2w8PxX5xdkewVjLhERxpnI0cRSMvkkKDU8t9P1cfBjQd877AznoaH1T0
         nuV3T9PwjKEwq/t65NAWuZGUKReuPkoS/G9eVU4vv/6a2K7FFQTefYfzMW1GYvr6l2iP
         I92w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZHopiEcE;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id hb42si2030812ejc.73.2021.07.05.21.40.03;
        Mon, 05 Jul 2021 21:40:35 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZHopiEcE;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229947AbhGFEmg (ORCPT <rfc822;ujwal.kundur.foss@gmail.com>
        + 99 others); Tue, 6 Jul 2021 00:42:36 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40304 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229926AbhGFEmf (ORCPT
        <rfc822;linux-crypto@vger.kernel.org>);
        Tue, 6 Jul 2021 00:42:35 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE51AC061574;
        Mon,  5 Jul 2021 21:39:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=Tm9bbwSLIXHzncYHK7SPpmMxLf8Q613BrbD6KMaacCU=; b=ZHopiEcE65spd6w6KieC7YH/9O
        7KIMWJOGo8MuL0N/hif+7In1wZ4nMYAxts4WI+bThg19A1gHVk+zbNn2Pdxi3smtBEqehnkKz3sUg
        k27f5BUV881/+Qpx5UChOFiMXm9luIVQZi/+TgVqY8ogi4Oa/Q4lrsG/BS/5k2aBCiOEpB7lsIxGC
        8Jzdbi9F6JmB7U+ZCCeU4u7wPa2bEo73kJeRXc2I+LSTTKq3IzhaQOjtTWzwJ7yX5yzQ5hKoD6zkY
        mJBkWTzUqrfkYMvY/Mxmr/0GsRBj026jW33bZuhIsz/UVAymC4vFNHkcOzqpC5t6HCwCADz2oI5fM
        /k80Alig==;
Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1m0crl-00Apu4-QR; Tue, 06 Jul 2021 04:39:31 +0000
Date:   Tue, 6 Jul 2021 05:39:25 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Leon Romanovsky <leon@kernel.org>,
        Shameerali Kolothum Thodi 
        <shameerali.kolothum.thodi@huawei.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        Linuxarm <linuxarm@huawei.com>,
        liulongfang <liulongfang@huawei.com>,
        "Zengtao (B)" <prime.zeng@hisilicon.com>,
        yuzenghui <yuzenghui@huawei.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        "Wangzhou (B)" <wangzhou1@hisilicon.com>
Subject: Re: [RFC v2 1/4] hisi-acc-vfio-pci: add new vfio_pci driver for
 HiSilicon ACC devices
Message-ID: <YOPefSD9x+mv5jO6@infradead.org>
References: <20210702095849.1610-1-shameerali.kolothum.thodi@huawei.com>
 <20210702095849.1610-2-shameerali.kolothum.thodi@huawei.com>
 <YOFdTnlkcDZzw4b/@unreal>
 <fc9d6b0b82254fbdb1cc96365b5bdef3@huawei.com>
 <d02dff3a-8035-ced1-7fc3-fcff791f9203@nvidia.com>
 <834a009bba0d4db1b7a1c32e8f20611d@huawei.com>
 <YONPGcwjGH+gImDj@unreal>
 <20210705183247.GU4459@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210705183247.GU4459@nvidia.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Mon, Jul 05, 2021 at 03:32:47PM -0300, Jason Gunthorpe wrote:
> It would be improved a bit by making the ops struct mutable and
> populating it at runtime like we do in RDMA. Then the PCI ops and
> driver ops could be merged together without the repetition.

No, that would be everything but an improvement.