Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Jul 2021 15:38:18 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     iLifetruth <yixiaonn@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        Qiang Liu <cyruscyliu@gmail.com>, yajin@vm-kernel.org
Subject: Re: crypto: prefix additional module autoloading with "crypto-"
Message-ID: <20210716073818.GA7773@gondor.apana.org.au>
References: <CABv53a8jyUXns9yu3xyd71_R+nNerU+Xj4i7a4rcZUH0bd52kw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABv53a8jyUXns9yu3xyd71_R+nNerU+Xj4i7a4rcZUH0bd52kw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Jul 08, 2021 at 12:33:47PM +0800, iLifetruth wrote:
>
> =========
> And the common fix pattern we found in each crypto-related module is as follows:
> 1. linux/drivers/crypto/padlock-aes.c
>        -MODULE_ALIAS("aes");
>        +MODULE_ALIAS_CRYPTO("aes");

This is already fixed in the current kernel.

> or in another module:
> 
> 2. linux/drivers/crypto/qat/qat_common/adf_ctl_drv.c
>       -MODULE_ALIAS("intel_qat");
>       +MODULE_ALIAS_CRYPTO("intel_qat");

This is not a bug.  The _CRYPTO suffix only applies to the ones
that are algorithm names.  intel_qat is not the name of an algorithm.

> ==========
> Even though commit 5d26a105b5a7 added those aliases for a large number
> of modules,  it is still missing some newly added crypto-related
> modules.
> For example:
> 1. for file linux/drivers/crypto/amcc/crypto4xx_trng.c in line 129,
> Module_ALIAS is used instead of MODULE_ALIAS_CRYPTO
>            MODULE_ALIAS("ppc4xx_rng");
>      In fact, ppc4xx-rng was integrated into crypto4xx on 2016-04-18
> by commit 5343e674f32fb8, which was committed about 2 years later than
> the security bug fixing patch(5d26a105b5a7) committed on 2014-11-24
> 
> More modules that may not have been fixed are as follows:
> 2. linux/crypto/crypto_user_base.c
>         MODULE_ALIAS("net-pf-16-proto-21");
> 3. linux/drivers/crypto/mxs-dcp.c
>         MODULE_ALIAS("platform:mxs-dcp");
> 4. linux/drivers/crypto/omap-sham.c
>         MODULE_ALIAS("platform:omap-sham");
> 5. linux/drivers/crypto/qcom-rng.c
>         MODULE_ALIAS("platform:" KBUILD_MODNAME);
> 6. linux/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
>         MODULE_ALIAS("platform:sun4i-ss");
> 7. linux/drivers/crypto/marvell/cesa/cesa.c
>         MODULE_ALIAS("platform:mv_crypto");
> 8. linux/drivers/crypto/qce/core.c
>         MODULE_ALIAS("platform:" KBUILD_MODNAME);

Nor are any of these algorithm names.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt