Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 17 Jul 2021 09:12:54 -0500
From:   Eric Biggers <ebiggers@kernel.org>
To:     Hannes Reinecke <hare@suse.de>
Cc:     Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
        Keith Busch <keith.busch@wdc.com>,
        linux-nvme@lists.infradead.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH 04/11] lib/base64: RFC4648-compliant base64 encoding
Message-ID: <YPLlZvVTMvjs8UGu@quark.localdomain>
References: <20210716110428.9727-1-hare@suse.de>
 <20210716110428.9727-5-hare@suse.de>
 <a6708951-76f6-21bb-f7fe-e4bb32cd0448@grimberg.me>
 <7f320b51-1077-9b3f-bf29-49d0753adf6c@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7f320b51-1077-9b3f-bf29-49d0753adf6c@suse.de>
Precedence: bulk

On Sat, Jul 17, 2021 at 04:00:20PM +0200, Hannes Reinecke wrote:
> On 7/17/21 8:16 AM, Sagi Grimberg wrote:
> > 
> > > Add RFC4648-compliant base64 encoding and decoding routines.
> > 
> > Looks good to me (although didn't look in the logic itself).
> > Can you maybe mention where was this taken from?
> 
> Umm ... yeah, I guess I can; I _think_ I've copied it from base64 routines
> in fs/crypto/fname.c, but I'll check.
> 

Note that it wasn't simply a copy, as you changed the variant of base64 that is
implemented.  So please make sure that you are very clear about which variant of
base64 it is, and update all the comments accordingly.

- Eric